pkg/25753 (make qt3-libs pkgview ready.)

Hi,

I now need the following patch to qt3-libs/Makefile rev.
1.57 to make the
port work with pkgviews. (I'm still using pkgviews because
I'm not sure
what it's been replaced by and I need to be able to run
several versions of
packages alongside each other).

cu Jo


RCS file: /pub/NetBSD-CVS/pkgsrc/x11/qt3-libs/Makefile,v
retrieving revision 1.57
diff -u -p -r1.57 Makefile
--- Makefile    23 Oct 2006 14:54:11 -0000      1.57
+++ Makefile    26 Nov 2006 23:09:53 -0000
 -6,6
+6,10  COMMENT=       C++ X GUI toolkit
 
 LIBQT=				$/lib/libqt-mt.la
 
+# set this before bsd.prefs.mk which sets
PKG_INSTALLATION_TYPE to
+# the wrong value.
+PKG_INSTALLATION_TYPES=	overwrite pkgviews
+
 .include "../../mk/bsd.prefs.mk"
 # XXX: hack - work round an ICE with GCC 3.3 on sparc
 .if $ == "NetBSD" &&
$ == "sparc"
 -44,6
+48,7  do-install:
 	$ $/plugins/imageformats
 	$ $
$/plugins/imageformats/libqjpeg.la
$/plugins/imageformats/
 	$ $
$/plugins/imageformats/libqmng.la
$/plugins/imageformats/
+	$ $/lib/pkgconfig/
 	$ $/lib/qt-mt.pc
$/lib/pkgconfig/
 
 .if $ == "Darwin" &&
empty(MACHINE_PLATFORM:MDarwin-[567].*)

> Hi,
>
> I now need the following patch to qt3-libs/Makefile
rev. 1.57 to  
> make the
> port work with pkgviews. (I'm still using pkgviews
because I'm not  
> sure
> what it's been replaced by and I need to be able to run
several  
> versions of
> packages alongside each other).

Greetings,

I think only the first part of your patch makes sense  
(PKG_INSTALLATION_TYPES=	overwrite pkgviews). The second
tries to  
create a directory, which should already exist, since
qt3-libs  
depeneds on devel/pkg-config, which creates
$/lib/pkgconfig,  
doesn't it?

Kind regards,
Adam

Hi Adam,

On Fri, Dec 01, 2006 at 12:21:01AM +0100, Adam wrote:
> I think only the first part of your patch makes sense  
> (PKG_INSTALLATION_TYPES=	overwrite pkgviews). The
second tries to  
> create a directory, which should already exist, since
qt3-libs  
> depeneds on devel/pkg-config, which creates
$/lib/pkgconfig,  
> doesn't it?

This is true for overwrite installations, but not with
pkgviews. Even though
the pkg-config package has a lib/pkgconfig directory and
this directory may
be present in the standard view, the directory does not
exist under the
PREFIX qt3-libs gets installed to
(/usr/pkg/packages/qt3-libs-<version>/).
Therefore, it needs to be created using e.g.
PKG_INSTALLATION_DIRS or
INSTALL_*_DIR, I chose the latter because of the similar
line above.

I don't know if pkgviews is still supposed to be supported
since I read
that it was about to be replaced, but since I don't know yet
what will
replace pkgviews I am still using it.

Regards,

cu Jo

-- 
La perfection est atteinte non quand il ne reste rien à
ajouter, mais quand
il ne reste rien à enlever.  (Antoine de Saint-Exupéry)