List Info

Thread: Patches: xep-0050/xep-0004 conformance




Patches: xep-0050/xep-0004 conformance
country flaguser name
South Africa
2007-10-25 03:36:31
hi all,

this is a resend of patches that was originally submitted in
march. 
unfortunately it was too late to make the 0.11 release. i've
also 
regenerated these patches against psi-0.11.

1. psi currently doesn't display xep-0004 reported items
when executing
a command (xep-0050 examples 8 and 9). the attached patch
allows this.
i've tested against openfire's admin commands (eg. Get list
of group
members).

2. xep-0004 specifies that <instructions> may not
contain 'n', instead
multiple <instructions> should be specified.

the following two patches implement that:
combine_text_of_similar_elements.{cpp|h).patch -> added a
method 
subTagsText that will combine the text of similar xml
elements
xdata_support_multiple_instructions.patch -> make use of
subTagsText
added above.

3. here are patches to display <note> elements from
adhoc commands:
3.1. psi.add_note_info_ahcommand.h.patch - add noteText_
& noteType_ to
ahcommand.h
3.2. psi.init_ahc_note.ahcommand.cpp.patch - initialize
noteText_/Type_
from xml.
3.3. psi.display_ahc_note.patch - creates a QLabel for note
display
purposes. i've concatenated the note type
(info/warning/error) with the
note text. displaying an icon might be better?

xdata_form_scrollarea.patch implements scroll bars for data
form larger 
than the screen display. the patch as is was diff'd against
a very old 
psi snapshot (feb '07). unfortunately i couldn't get it to
work when 
using with psi-0.11. wouldn't it make sense to rather add
the 
QScrollArea to xdata_widget, instead of to eventldg? any
other ideas?

regards
roelof

_______________________________________________
Psi-Devel mailing list
Psi-Devellists.affinix.com
http://lists.affinix.com/listinfo.cgi/psi-devel-affin
ix.com

  
  
  
  
  
  
  
  
Re: Patches: xep-0050/xep-0004 conformance
country flaguser name
United Kingdom
2007-10-25 04:17:19
On 25 Oct 2007, at 09:36, Roelof Naude wrote:
> this is a resend of patches that was originally
submitted in march.  
> unfortunately it was too late to make the 0.11 release.
i've also  
> regenerated these patches against psi-0.11.

Thanks for resubmitting these (it's the safest way to make
sure we  
don't forget about them after a code freeze etc.). I'll have
a look  
at them in the near future.

/K
_______________________________________________
Psi-Devel mailing list
Psi-Devellists.affinix.com
http://lists.affinix.com/listinfo.cgi/psi-devel-affin
ix.com

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )