List Info

Thread: SVN precommit hook




SVN precommit hook
user name
2007-07-11 07:03:56

I just got this traceback trying to do a rather large checkin:

Transmitting file data ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................svn: Commit failed (details follow):
svn: 'pre-commit' hook failed with error output:
file /python/branches/p3yk-noslice/Lib/test/string_tests.py is not whitespace-normalized
file /python/branches/p3yk-noslice/Doc/tools/buildindex.py is not whitespace-normalized
file /python/branches/p3yk-noslice/Lib/test/test_array.py is not whitespace-normalized
Traceback (most recent call last):
  File "/data/repos/projects/hooks/checkwhitespace.py", line 50, in ?
  File "/var/lib/python-support/python2.4/svn/core.py", line 217, in run_app
  File "/data/repos/projects/hooks/checkwhitespace.py", line 32, in main
 ; File "/var/lib/python-support/python2.4/libsvn/fs.py", line 381, in svn_fs_node_prop
libsvn._core.SubversionException: ("Can't open file '/data/repos/projects/db/transactions/56255- 1.txn/props';: Too many open files";, 24)

I';m not complaining about the whitespace-normalization issues, but rather the open files issue ;-P It sounds like a buglet somewhere, although it may be in libsvn.

--
Thomas Wouters < thomaspython.org">thomaspython.org>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
Re: SVN precommit hook
user name
2007-07-11 07:09:34

On 7/11/07, Thomas Wouters < thomaspython.org">thomaspython.org> wrote:

I just got this traceback trying to do a rather large checkin:

Transmitting file data ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................svn: Commit failed (details follow):
svn: 'pre-commit' hook failed with error output:
file /python/branches/p3yk-noslice/Lib/test/string_tests.py is not whitespace-normalized
file /python/branches/p3yk-noslice/Doc/tools/buildindex.py is not whitespace-normalized
file /python/branches/p3yk-noslice/Lib/test/test_array.py is not whitespace-normalized
Traceback (most recent call last):
&nbsp; File "/data/repos/projects/hooks/checkwhitespace.py&quot;, line 50, in ?
  File "/var/lib/python-support/python2.4/svn/core.py&quot;, line 217, in run_app
  File "/data/repos/projects/hooks/checkwhitespace.py&quot;, line 32, in main
 ; File "/var/lib/python-support/python2.4/libsvn/fs.py&quot;, line 381, in svn_fs_node_prop
libsvn._core.SubversionException: ("Can't open file '/data/repos/projects/db/transactions/56255- 1.txn/props';: Too many open files";, 24)

I';m not complaining about the whitespace-normalization issues, but rather the open files issue ;-P It sounds like a buglet somewhere, although it may be in libsvn.

Oh, and for the record, it also fails when there are no whitespace issues to fix. I can't check in my (admittedly somewhat big) svnmerge now. It touches about 1130 files.

--
Thomas Wouters < thomaspython.org">thomaspython.org>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
Re: SVN precommit hook
user name
2007-07-11 08:46:18


On 7/11/07, Thomas Wouters < thomaspython.org">thomaspython.org> wrote:
libsvn._core.SubversionException: ("Can't open file '/data/repos/projects/db/transactions/56255- 1.txn/props';: Too many open files";, 24)

Fixed. The problem was that checkwhitespace.py wasn't closing the SVN streams it was reading. Added the 'svn_stream_close' call and my checkin got through. Should be safe to do massive checkins from now on

--
Thomas Wouters < thomaspython.org">thomaspython.org>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
Re: SVN precommit hook
user name
2007-07-11 15:46:47
> Fixed. The problem was that checkwhitespace.py wasn't
closing the SVN
> streams it was reading. Added the 'svn_stream_close'
call and my checkin
> got through. Should be safe to do massive checkins from
now on 

Thanks for fixing it. Those of you having access to
dinsdale, feel free
to temporarily disable this particular hook in the future if
you find it
is in your way; don't forgot to report the problem at least,
and try
enabling it after the questionable checkin has completed.

Regards,
Martin
_______________________________________________
Python-Dev mailing list
Python-Devpython.org
ht
tp://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/p
ython-dev/nessto%40sharedlog.com

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )