Re: lzma handling is broken (4.4.8)

On February 26, 2007 1:56:22 AM -0800 Frank Cusack
<fcusackfcusack.com> 
wrote:
> don't know when lzma was introduced to rpm, but the
format (not
> necessarily rpm) is broken.  sigh.
>
> rpmio/macro.c:
>     /* XXX Ick, LZMA has no magic. See http://lkml.org/lk
ml/2005/6/13/285
> */
>     if (magic[ 9] == 0x00 && magic[10] == 0x00
&&
>         magic[11] == 0x00 && magic[12] == 0x00)
/* lzmash */
>         *compressed = COMPRESSED_LZMA;
>
> I have a few tar files that this breaks on.  Maybe all
tar files?
>
> I guess I *could* gzip the tar's, but it wouldn't be
the original
> format so I prefer to #ifdef this code out since I'll
never see an
> lzma file.

I guess a yucky but maybe acceptable fix is to test the file
extension
before assuming lzma.

-frank
_______________________________________________
Rpm-devel mailing list
Rpm-devellists.dulug.duke.edu
https://lists.dulug.duke.edu/mailman/listinfo/rpm-devel

On February 26, 2007 2:04:22 AM -0800 Frank Cusack
<fcusackfcusack.com> 
wrote:
> I guess a yucky but maybe acceptable fix is to test the
file extension
> before assuming lzma.

duh ... or test for tar magic.  patch attached.

-frank
_______________________________________________
Rpm-devel mailing list
Rpm-devellists.dulug.duke.edu
https://lists.dulug.duke.edu/mailman/listinfo/rpm-devel

On Feb 26, 2007, at 5:04 AM, Frank Cusack wrote:

> On February 26, 2007 1:56:22 AM -0800 Frank Cusack  
> <fcusackfcusack.com> wrote:
>> don't know when lzma was introduced to rpm, but the
format (not
>> necessarily rpm) is broken.  sigh.
>>
>> rpmio/macro.c:
>>     /* XXX Ick, LZMA has no magic. See http://lkml.org/lkml/ 
>> 2005/6/13/285
>> */
>>     if (magic[ 9] == 0x00 && magic[10] ==
0x00 &&
>>         magic[11] == 0x00 && magic[12] ==
0x00) /* lzmash */
>>         *compressed = COMPRESSED_LZMA;
>>
>> I have a few tar files that this breaks on.  Maybe
all tar files?
>>
>> I guess I *could* gzip the tar's, but it wouldn't
be the original
>> format so I prefer to #ifdef this code out since
I'll never see an
>> lzma file.
>
> I guess a yucky but maybe acceptable fix is to test the
file extension
> before assuming lzma.
>

Yuck. No way ...

73 de Jeff

_______________________________________________
Rpm-devel mailing list
Rpm-devellists.dulug.duke.edu
https://lists.dulug.duke.edu/mailman/listinfo/rpm-devel