Subclassing svn::Client

Hi,

before I file a wishlist item in the bugtracker I'd like to
get some
input on this from the developers.

I'm currently working on a subversion plugin for KDevelop4
(www.kdevelop.org) and am doing that with the svncpp
library. However I
found that the library misses one or two needed methods, for
example it
currently can only create a diff for a working copy path
using 2
revisions. In the subversion plugin I'll also need the
ability to create
a diff from two different paths.

So I tried to subclass svn::Client and add the new methods
in that
subclass. Worked out almost nicely, except that
svn::Client::getContext
returns a const Context* which cannot be used with the C-api
functions.
I work around this currently with a const_cast, but thats
rather nasty
IMHO.

So what I'd like to know is
a) would you consider extending the Client class with a
non-const
getContext() so that subclasses can use it to provide their
own methods
b) Are you interested in patches extending the Client class
with new
functions that cover more of the C-API? (I've also noticed
that add()
has no force parameter)

Andreas

-- 
You will be successful in love.

I would go for b)
and Yes, patches are welcome 

Xela

Andreas Pakulat schrieb:
> Hi,
> 
> before I file a wishlist item in the bugtracker I'd
like to get some
> input on this from the developers.
> 
> I'm currently working on a subversion plugin for
KDevelop4
> (www.kdevelop.org) and am doing that with the svncpp
library. However I
> found that the library misses one or two needed
methods, for example it
> currently can only create a diff for a working copy
path using 2
> revisions. In the subversion plugin I'll also need the
ability to create
> a diff from two different paths.
> 
> So I tried to subclass svn::Client and add the new
methods in that
> subclass. Worked out almost nicely, except that
svn::Client::getContext
> returns a const Context* which cannot be used with the
C-api functions.
> I work around this currently with a const_cast, but
thats rather nasty
> IMHO.
> 
> So what I'd like to know is
> a) would you consider extending the Client class with a
non-const
> getContext() so that subclasses can use it to provide
their own methods
> b) Are you interested in patches extending the Client
class with new
> functions that cover more of the C-API? (I've also
noticed that add()
> has no force parameter)
> 
> Andreas
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscriberapidsvn.tigris.org
For additional commands, e-mail: dev-helprapidsvn.tigris.org

On 08.10.07 15:40:34, Alexander Mueller wrote:
> I would go for b)
> and Yes, patches are welcome 

Ok, I've created new issue tracker items for a) and 2 new
diff
functions.

http://rapidsvn.tigris.org/issues/show_bug.cgi?id=536
http://rapidsvn.tigris.org/issues/show_bug.cgi?id=537

Just let me know if thats ok for you or wether I should send
such things
directly to this list.

Andreas

-- 
Beware of a tall black man with one blond shoe.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscriberapidsvn.tigris.org
For additional commands, e-mail: dev-helprapidsvn.tigris.org