List Info

Thread: multipathd crash on shutdown




multipathd crash on shutdown
country flaguser name
Germany
2008-04-30 04:03:24
On shutdown multipathd flushes its internal message queue;
but we have to check if the messages on the queue are not
empty.

Signed-off-by: Hannes Reinecke <haresuse.de>
---
 libmultipath/log_pthread.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/libmultipath/log_pthread.c
b/libmultipath/log_pthread.c
index 5a82b6a..8976bfb 100644
--- a/libmultipath/log_pthread.c
+++ b/libmultipath/log_pthread.c
 -33,7
+33,8  static void flush_logqueue (void)
 		pthread_mutex_lock(logq_lock);
 		empty = log_dequeue(la->buff);
 		pthread_mutex_unlock(logq_lock);
-		log_syslog(la->buff);
+		if (!empty)
+			log_syslog(la->buff);
 	} while (empty == 0);
 }
 
-- 
1.5.2.4

--
dm-devel mailing list
dm-develredhat.com
http
s://www.redhat.com/mailman/listinfo/dm-devel

[1]

about | contact  Other archives ( Real Estate discussion Medical topics )