Re: Gapless/crossfade playback in svn trunk

Hello,

Just tested the new backend, here is some feedback:

* I experience lag (about 1sec) in skip / go back / play /
pause actions
* Position slider behavior is not as reliable as in the
standard
backend: sometimes it doesn't show the actual position, and
when
crossfade is activated the end of the song is hardly
reacheable
(because it has jsut skipped to the next song)
* my spectrum analyser plugin doesn't work with it (It
listens to
messages on the bus, I'll investigate that)
* the zero-gap
* it crashes when playing mpc files : Rhythmbox-ERROR **:
file
rb-player-gst-xfade.c: line 2088 (preroll_stream): assertion
failed:
(stream->src_blocked)
aborting...
* the sound is slightly over-saturated.
* gapeless functionnality seems rather solid for what I
tested, even with mp3.


cheers,
Christophe




On 3/31/07, Jonathan Matthew <jonathankaolin.wh9.net> wrote:
> On Fri, Mar 30, 2007 at 06:00:32PM +0200, Jan Schmidt
wrote:
> >
> > I've been using the crossfading backend for since
you committed it. Damn
> > fine work, sir!
> >
> > Do you know what the problem with visualisation
is? What in CVS core
> > broke it? It'd suck to release with such a
regression.
>
> I haven't looked into it much, but I'm pretty sure it
broke around the
> time of the recent latency changes.
>
> > I notice a little trouble seeking - it takes
longer than it should for
> > the seek to actually occur, which should be
unnecessary in the bigger
> > picture. Do you know what's causing that?
>
> It's probably because the seeks it does don't flush the
whole pipeline,
> only the stream's bin.  Maybe if there's only one
stream playing, I can
> make it flush the whole thing?
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-develgnome.org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel

>
_______________________________________________
rhythmbox-devel mailing list
rhythmbox-develgnome.org
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel

On Sat, Mar 31, 2007 at 01:53:02PM +0200, Christophe Dehais
wrote:
> Hello,
> 
> Just tested the new backend, here is some feedback:
> 
> * I experience lag (about 1sec) in skip / go back /
play / pause actions

This is a known problem that I'm not sure I'll be able to
fix entirely.

> * Position slider behavior is not as reliable as in the
standard
> backend: sometimes it doesn't show the actual position,
and when
> crossfade is activated the end of the song is hardly
reacheable
> (because it has jsut skipped to the next song)

If you could clarify when it doesn't show the actual
position, how badly
it gets it wrong, etc., that would be helpful.  The way the
crossfading
player backend does position queries tends to show up bugs
in GStreamer
plugins that just using playbin doesn't (it sometimes ends
up querying
decoders rather than sinks), so it's possible that problems
with the
song position will be media type specific.

We probably need to do something more intelligent with
regard to track
changes while the user is moving the position slider.

> * it crashes when playing mpc files : Rhythmbox-ERROR
**: file
> rb-player-gst-xfade.c: line 2088 (preroll_stream):
assertion failed:
> (stream->src_blocked)
> aborting...

Bug #424734; if you can reliably reproduce this, attaching
gstreamer
debug output (GST_DEBUG=*:4) to the bug would be most
helpful.  I
suspect this is a bug in the musepack decoder plugin.

> * the sound is slightly over-saturated.

I have no real idea what could be causing this.  The
playback pipeline
shouldn't introduce any gain at any point.
_______________________________________________
rhythmbox-devel mailing list
rhythmbox-develgnome.org
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel

> * my spectrum analyser plugin doesn't work with it (It
listens to
> messages on the bus, I'll investigate that)


The problem is that I register a bus handler when notified
by this
portion of code of gst-player-gst.c

	/* let plugins add bits to playbin */
	g_object_notify (G_OBJECT (mp), "playbin");

maybe we should clarify the way plugins can access the gst
bus ?

Christophe
_______________________________________________
rhythmbox-devel mailing list
rhythmbox-develgnome.org
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel