|
List Info
Thread: lib/rubygems/open-uri.rb needs to stay gone
|
|
| lib/rubygems/open-uri.rb needs to stay
gone |
  United States |
2007-02-12 17:57:05 |
In order to fix proxy with password, rubygems/open-uri.rb
was re-added.
Requiring both rubygems.rb and open-uri.rb causes inifinite
loops
(#open calls itself since it is aliased twice).
The correct way to fix this is not to continually re-import
open-
uri.rb, but to get changes back-ported from 1.9 to 1.8.
There's a
realease coming RSN (freeze in days!). Can somebody
spearhead this?
I don't know enough about proxies to make sure the right
change is
made to the 1.8 branch.
PS: This breaks Tinderbox, since Tinderbox requires both.
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
|
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |
  United States |
2007-02-12 19:34:50 |
On Feb 12, 2007, at 15:57, Eric Hodel wrote:
> In order to fix proxy with password,
rubygems/open-uri.rb was re-
> added.
>
> Requiring both rubygems.rb and open-uri.rb causes
inifinite loops
> (#open calls itself since it is aliased twice).
>
> The correct way to fix this is not to continually
re-import open-
> uri.rb, but to get changes back-ported from 1.9 to 1.8.
There's a
> realease coming RSN (freeze in days!). Can somebody
spearhead this?
> I don't know enough about proxies to make sure the
right change is
> made to the 1.8 branch.
Note that I really need someone to figure out what the right
patch
from 1.9 to 1.8 is, and post it to ruby-core. I can help
push this
through for 1.8.6.
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
|
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |

|
2007-02-14 23:52:10 |
|
Hi, Eric.
Just to clarify. We need to port proxy authorization feature that fixes our problem from
http://svn.ruby-lang.org/repos/ruby/trunk to
http://svn.ruby-lang.org/repos/ruby/branches/ruby_1_8_5
Am I right?
On 2/14/07, Eric Hodel < drbrain segment7.net">drbrain segment7.net
> wrote:On Feb 12, 2007, at 17:34, Eric Hodel wrote: > On Feb 12, 2007, at 15:57, Eric Hodel wrote:
> >> In order to fix proxy with password, rubygems/open-uri.rb was re- >> added. >> >> Requiring both rubygems.rb and open-uri.rb causes inifinite loops >> (#open calls itself since it is aliased twice).
>> >> The correct way to fix this is not to continually re-import open- >> uri.rb, but to get changes back-ported from 1.9 to 1.8. There's a >> realease coming RSN (freeze in days!). Can somebody spearhead this?
>> I don't know enough about proxies to make sure the right change is >> made to the 1.8 branch. > > Note that I really need someone to figure out what the right patch > from 1.9 to
1.8 is, and post it to ruby-core. I can help push this > through for 1.8.6.
Really, it would be great if I could get this patched correctly on 1.8.6 (and add a workaround for 1.8.5 for the next release of
RubyGems). Breaking open-uri this way is uncool :/
-- anatol (http://feeds.feedburner.com/apomozov-eng)
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |
  United States |
2007-02-15 12:54:02 |
On Feb 14, 2007, at 21:52, Anatol Pomozov wrote:
> Hi, Eric.
>
> Just to clarify. We need to port proxy authorization
feature that
> fixes our problem from
>
> http://svn.
ruby-lang.org/repos/ruby/trunk
> to
> http://svn.ruby-lang.org/repos/ruby/branches/ruby_1_8_5
a>
>
> Am I right?
Correct.
> On 2/14/07, Eric Hodel <drbrain segment7.net > wrote:On Feb 12,
> 2007, at 17:34, Eric Hodel wrote:
> > On Feb 12, 2007, at 15:57, Eric Hodel wrote:
> >
> >> In order to fix proxy with password,
rubygems/open-uri.rb was re-
> >> added.
> >>
> >> Requiring both rubygems.rb and open-uri.rb
causes inifinite loops
> >> (#open calls itself since it is aliased
twice).
> >>
> >> The correct way to fix this is not to
continually re-import open-
> >> uri.rb, but to get changes back-ported from
1.9 to 1.8. There's a
> >> realease coming RSN (freeze in days!). Can
somebody spearhead
> this?
> >> I don't know enough about proxies to make sure
the right change is
> >> made to the 1.8 branch.
> >
> > Note that I really need someone to figure out what
the right patch
> > from 1.9 to 1.8 is, and post it to ruby-core. I
can help push this
> > through for 1.8.6.
>
> Really, it would be great if I could get this patched
correctly on
> 1.8.6 (and add a workaround for 1.8.5 for the next
release of
> RubyGems). Breaking open-uri this way is uncool :/
>
>
>
> --
> anatol (http://feeds
.feedburner.com/apomozov-eng)
> _______________________________________________
> Rubygems-developers mailing list
> Rubygems-developers rubyforge.org
> http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
|
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |

|
2007-02-15 15:19:08 |
|
OK. Here is patch that contains proxy authorization changes.
But as for me I would just copy open-uri.rb from trunk to 1.8.5 branch, because of 2 reasons 1) version from trunk is tested much better (we've used it in
rubygems-0.9.2) 2) It does not contained any API changes. Trunk version fixes 2 bugs: with proxy authorization and with SSL.
Anyway if copying is not possible (but I am still voting for it) I would like that anyone from you try to test this patch. Just apply patch to your current
open-uri.rb file and remove open-uri lib from rubygems.
I've just tested it. WinXP ruby 1.8.4, rubygems 0.9.2. Works fine.
On 2/15/07, Anatol Pomozov
< anatol.pomozov gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">anatol.pomozov gmail.com> wrote:
Hi, Eric.
Just to clarify. We need to port proxy authorization feature that fixes our problem from
http://svn.ruby-lang.org/repos/ruby/trunk to
http://svn.ruby-lang.org/repos/ruby/branches/ruby_1_8_5
Am I right?
On 2/14/07, Eric Hodel <
drbrain segment7.net" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">drbrain segment7.net
> wrote:On Feb 12, 2007, at 17:34, Eric Hodel wrote: > On Feb 12, 2007, at 15:57, Eric Hodel wrote:
> >> In order to fix proxy with password, rubygems/open-uri.rb was re- >> added. >> >> Requiring both rubygems.rb and open-uri.rb causes inifinite loops >> (#open calls itself since it is aliased twice).
>> >> The correct way to fix this is not to continually re-import open- >> uri.rb, but to get changes back-ported from 1.9 to 1.8. There's a >> realease coming RSN (freeze in days!). Can somebody spearhead this?
>> I don't know enough about proxies to make sure the right change is >> made to the 1.8 branch. > > Note that I really need someone to figure out what the right patch > from 1.9 to
1.8 is, and post it to ruby-core. I can help push this > through for 1.8.6.
Really, it would be great if I could get this patched correctly on 1.8.6 (and add a workaround for 1.8.5 for the next release of
RubyGems). Breaking open-uri this way is uncool :/
|
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |

|
2007-02-15 16:41:35 |
On 2/15/07, Anatol Pomozov <anatol.pomozov gmail.com> wrote:
> OK. Here is patch that contains proxy authorization
changes.
I think Eric is suggesting that this be posted to ruby-core;
a soft
code freeze has been imposed for 1.8.6, but this is
important enough
that I think it would work.
-austin
--
Austin Ziegler * halostatue gmail.com * http://www.halostatue.ca/
a>
* austin halostatue.ca * http://www.halostatue.
ca/feed/
* austin zieglers.ca
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
|
|
| Re: lib/rubygems/open-uri.rb needs to
stay gone |
  United States |
2007-02-15 19:53:09 |
On Feb 15, 2007, at 14:41, Austin Ziegler wrote:
> On 2/15/07, Anatol Pomozov <anatol.pomozov gmail.com> wrote:
>> OK. Here is patch that contains proxy authorization
changes.
>
> I think Eric is suggesting that this be posted to
ruby-core; a soft
> code freeze has been imposed for 1.8.6, but this is
important enough
> that I think it would work.
I've forwarded Anatol's mail with a bit of extra explanation
to ruby-
core, since I think we missed the freeze.
_______________________________________________
Rubygems-developers mailing list
Rubygems-developers rubyforge.org
http://rubyforge.org/mailman/listinfo/rubygems-develope
rs
|
|
[1-7]
|
|