WRONG TLS CODE IN SIP-COMMUNICATOR

Nice catch Pablo!

I've applied, committed and acked your fix on the "Team
and 
Contributors" page.

Let me know if it works now.

Thanks!
Emil



Pablo wrote:
> Hi!
> 
>  
> 
> I think that the next code is wrong:
> 
>  
> 
> package net.java.sip.communicator.impl.protocol.sip;
> 
> ProtocolProviderServiceSipImpl.java
> 
> Línea 1549:
> 
>  
> 
> if(registrarTransport != null &&
registrarTransport.length() > 0)
> 
>         {
> 
>             if( !
registrarTransport.equals(ListeningPoint.UDP)
> 
>                 ||
!registrarTransport.equals(ListeningPoint.TCP)
> 
>                 ||
!registrarTransport.equals(ListeningPoint.TLS))
> 
>             {
> 
>                 throw new
IllegalArgumentException(registrarTransport
> 
>                     + " is not a valid transport
protocol. Transport 
> must be "
> 
>                     +"left blanc or set to TCP,
UDP or TLS.");
> 
>             }
> 
>         }
> 
>  
> 
> This code make use UDP always. I think it must be:
> 
>  
> 
> if(registrarTransport != null &&
registrarTransport.length() > 0)
> 
>         {
> 
>             if( !
registrarTransport.equals(ListeningPoint.UDP)
> 
>                 &&
!registrarTransport.equals(ListeningPoint.TCP)
> 
>                 &&
!registrarTransport.equals(ListeningPoint.TLS))
> 
>             {
> 
>                 throw new
IllegalArgumentException(registrarTransport
> 
>                     + " is not a valid transport
protocol. Transport 
> must be "
> 
>                     +"left blanc or set to TCP,
UDP or TLS.");
> 
>             }
> 
>         }
> 
>  
> 
> Tell me your opinion. Thanks.
> 
>  
> 
> Pablo L.
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hi!

I'm trying to make TLS work. My problem now is the
certificates. I'm trying
to bypass the trust test in Jain SIP.

I think there is other problem to fix. Before the lines that
you've fixed:

//registrar transport
        String registrarTransport = (String)
accountID.getAccountProperties()
            .get(ProtocolProviderFactory.SERVER_TRANSPORT);

I've change it by:

//registrar transport
        String registrarTransport = (String)
accountID.getAccountProperties()
           
.get(ProtocolProviderFactory.PREFERRED_TRANSPORT);

Because SERVER_TRANSPORT doesn't exists in the conf file.

Regards. Pablo.


-----Mensaje original-----
De: Emil Ivov [mailto:emchosip-communicator.org] 
Enviado el: viernes, 09 de febrero de 2007 12:06
Para: devsip-communicator.dev.java.net
CC: emchodev.java.net; Pablo
Asunto: Re: [sip-comm-dev] WRONG TLS CODE IN
SIP-COMMUNICATOR

Nice catch Pablo!

I've applied, committed and acked your fix on the "Team
and 
Contributors" page.

Let me know if it works now.

Thanks!
Emil



Pablo wrote:
> Hi!
> 
>  
> 
> I think that the next code is wrong:
> 
>  
> 
> package net.java.sip.communicator.impl.protocol.sip;
> 
> ProtocolProviderServiceSipImpl.java
> 
> Línea 1549:
> 
>  
> 
> if(registrarTransport != null &&
registrarTransport.length() > 0)
> 
>         {
> 
>             if( !
registrarTransport.equals(ListeningPoint.UDP)
> 
>                 ||
!registrarTransport.equals(ListeningPoint.TCP)
> 
>                 ||
!registrarTransport.equals(ListeningPoint.TLS))
> 
>             {
> 
>                 throw new
IllegalArgumentException(registrarTransport
> 
>                     + " is not a valid transport
protocol. Transport 
> must be "
> 
>                     +"left blanc or set to TCP,
UDP or TLS.");
> 
>             }
> 
>         }
> 
>  
> 
> This code make use UDP always. I think it must be:
> 
>  
> 
> if(registrarTransport != null &&
registrarTransport.length() > 0)
> 
>         {
> 
>             if( !
registrarTransport.equals(ListeningPoint.UDP)
> 
>                 &&
!registrarTransport.equals(ListeningPoint.TCP)
> 
>                 &&
!registrarTransport.equals(ListeningPoint.TLS))
> 
>             {
> 
>                 throw new
IllegalArgumentException(registrarTransport
> 
>                     + " is not a valid transport
protocol. Transport 
> must be "
> 
>                     +"left blanc or set to TCP,
UDP or TLS.");
> 
>             }
> 
>         }
> 
>  
> 
> Tell me your opinion. Thanks.
> 
>  
> 
> Pablo L.
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hi again Pablo,

I've committed that one as well.

Thanks!
Emil

Pablo wrote:
> Hi!
> 
> I'm trying to make TLS work. My problem now is the
certificates. I'm trying
> to bypass the trust test in Jain SIP.
> 
> I think there is other problem to fix. Before the lines
that you've fixed:
> 
> //registrar transport
>         String registrarTransport = (String)
> accountID.getAccountProperties()
>            
.get(ProtocolProviderFactory.SERVER_TRANSPORT);
> 
> I've change it by:
> 
> //registrar transport
>         String registrarTransport = (String)
> accountID.getAccountProperties()
>            
.get(ProtocolProviderFactory.PREFERRED_TRANSPORT);
> 
> Because SERVER_TRANSPORT doesn't exists in the conf
file.
> 
> Regards. Pablo.
> 
> 
> -----Mensaje original-----
> De: Emil Ivov [mailto:emchosip-communicator.org] 
> Enviado el: viernes, 09 de febrero de 2007 12:06
> Para: devsip-communicator.dev.java.net
> CC: emchodev.java.net; Pablo
> Asunto: Re: [sip-comm-dev] WRONG TLS CODE IN
SIP-COMMUNICATOR
> 
> Nice catch Pablo!
> 
> I've applied, committed and acked your fix on the
"Team and 
> Contributors" page.
> 
> Let me know if it works now.
> 
> Thanks!
> Emil
> 
> 
> 
> Pablo wrote:
>> Hi!
>>
>>  
>>
>> I think that the next code is wrong:
>>
>>  
>>
>> package
net.java.sip.communicator.impl.protocol.sip;
>>
>> ProtocolProviderServiceSipImpl.java
>>
>> Línea 1549:
>>
>>  
>>
>> if(registrarTransport != null &&
registrarTransport.length() > 0)
>>
>>         {
>>
>>             if( !
registrarTransport.equals(ListeningPoint.UDP)
>>
>>                 ||
!registrarTransport.equals(ListeningPoint.TCP)
>>
>>                 ||
!registrarTransport.equals(ListeningPoint.TLS))
>>
>>             {
>>
>>                 throw new
IllegalArgumentException(registrarTransport
>>
>>                     + " is not a valid
transport protocol. Transport 
>> must be "
>>
>>                     +"left blanc or set to
TCP, UDP or TLS.");
>>
>>             }
>>
>>         }
>>
>>  
>>
>> This code make use UDP always. I think it must be:
>>
>>  
>>
>> if(registrarTransport != null &&
registrarTransport.length() > 0)
>>
>>         {
>>
>>             if( !
registrarTransport.equals(ListeningPoint.UDP)
>>
>>                 &&
!registrarTransport.equals(ListeningPoint.TCP)
>>
>>                 &&
!registrarTransport.equals(ListeningPoint.TLS))
>>
>>             {
>>
>>                 throw new
IllegalArgumentException(registrarTransport
>>
>>                     + " is not a valid
transport protocol. Transport 
>> must be "
>>
>>                     +"left blanc or set to
TCP, UDP or TLS.");
>>
>>             }
>>
>>         }
>>
>>  
>>
>> Tell me your opinion. Thanks.
>>
>>  
>>
>> Pablo L.
>>
> 
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
> 
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net