Jabber account creation (new feature)

Hi Nicolas,

I've finished revision of your plugin and have committed
your code. 
You've done some pretty good work! I've just made some minor
changes in 
order to make the plugin fit better to sip-communicator code
conventions.

Here's the list of modifications:

- I've removed the I18NStringJabberWizard class and have
replace it by a 
method getMnemonic in the Resources class.

- In the JabberServerChooserDialog have moved the TableModel
from the 
init method to a private class. Within the TableModel have
also added a 
constructor, which loads the comments.xml file and have
changed the 
getValueAt method to access the DOM document instead of
opening the file 
each time.

- Renamed the comments.xml to servercomments.xml.

- Added some more comments and slightly changed some label
texts.

- I've slightly reorganized some classes (moved the
constructor in the 
beginning of the class, changed the place of some of the
methods).

- Added the RESOURCE and RESOURCE_PRIORITY properties in the

ProtocolProviderFactory.

- In the ProtocolProviderServiceJabberImpl added a check for
null for 
accountResource before invoking the connection.login(userID,
password, 
accountResource). I've also moved the presence.setPriority()
to the 
OperationSetPersistentPresenceJabberImpl.

Thanks for your great contribution!

Yana

Nicolas Grandclaude wrote:
> Hi,
> 
> I work fot my student project (50 hours) on the Jabber
protocol
> implementation in SIP Communicator. My subject was to
add the creation
> of new account in SIP Communicator.
> 
> I do it with the enhancement of the jabber account
registration plugin.
> I add a new button for new account in the registration
form on the
> model of the aim registration plugin. When we click on
this button, a
> new form appears with server name, new user id and
password field. A
> button "choose" is at the right of the server
field. It opens a new
> dialog with a JTable contains servers from servers.xml
of jabber.org
> (http://www.jabber.o
rg/servers.xml). This file is save on disk in the
> user home for prevent user or jabber.org offline. When
we valid the new
> account dialog, the account is created and the field of
the wizard are
> filled.
> 
> Also, I add two new field in the Jabber account wizard
: ressource and
> priority. These fields are used by the Jabber server
when we are
> connected in two places in the same time. They are
saved in the sip
> communicator config file like other.
> 
> Currently bug :
> - The wizard window size is often too small and we can
see the new
> button.
> 
> I attach with the mail three patch files (they applies
on the CVS tree
> of today : 2007-05-28) :
> - build_xml.patch : Modify build.xml for add smack with
Jabber Wizard
> - protocol_jabber.patch : Modify the Jabber protocol
provider service
> for the two new fields.
> - jabber_plugin.patch : Main patch. The wizard with rhe
new features.
> 
> --
> Regards.
> Nicolas Grandclaude
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

	Where is the list of S-C plugins available for install?


On Thu, 2007-05-31 at 12:41 +0200, Yana Stamcheva wrote:
> Hi Nicolas,
> 
> I've finished revision of your plugin and have
committed your code. 
> You've done some pretty good work! I've just made some
minor changes in 
> order to make the plugin fit better to sip-communicator
code conventions.
> 
> Here's the list of modifications:
> 
> - I've removed the I18NStringJabberWizard class and
have replace it by a 
> method getMnemonic in the Resources class.
> 
> - In the JabberServerChooserDialog have moved the
TableModel from the 
> init method to a private class. Within the TableModel
have also added a 
> constructor, which loads the comments.xml file and have
changed the 
> getValueAt method to access the DOM document instead of
opening the file 
> each time.
> 
> - Renamed the comments.xml to servercomments.xml.
> 
> - Added some more comments and slightly changed some
label texts.
> 
> - I've slightly reorganized some classes (moved the
constructor in the 
> beginning of the class, changed the place of some of
the methods).
> 
> - Added the RESOURCE and RESOURCE_PRIORITY properties
in the 
> ProtocolProviderFactory.
> 
> - In the ProtocolProviderServiceJabberImpl added a
check for null for 
> accountResource before invoking the
connection.login(userID, password, 
> accountResource). I've also moved the
presence.setPriority() to the 
> OperationSetPersistentPresenceJabberImpl.
> 
> Thanks for your great contribution!
> 
> Yana
> 
> Nicolas Grandclaude wrote:
> > Hi,
> > 
> > I work fot my student project (50 hours) on the
Jabber protocol
> > implementation in SIP Communicator. My subject was
to add the creation
> > of new account in SIP Communicator.
> > 
> > I do it with the enhancement of the jabber account
registration plugin.
> > I add a new button for new account in the
registration form on the
> > model of the aim registration plugin. When we
click on this button, a
> > new form appears with server name, new user id and
password field. A
> > button "choose" is at the right of the
server field. It opens a new
> > dialog with a JTable contains servers from
servers.xml of jabber.org
> > (http://www.jabber.o
rg/servers.xml). This file is save on disk in the
> > user home for prevent user or jabber.org offline.
When we valid the new
> > account dialog, the account is created and the
field of the wizard are
> > filled.
> > 
> > Also, I add two new field in the Jabber account
wizard : ressource and
> > priority. These fields are used by the Jabber
server when we are
> > connected in two places in the same time. They are
saved in the sip
> > communicator config file like other.
> > 
> > Currently bug :
> > - The wizard window size is often too small and we
can see the new
> > button.
> > 
> > I attach with the mail three patch files (they
applies on the CVS tree
> > of today : 2007-05-28) :
> > - build_xml.patch : Modify build.xml for add smack
with Jabber Wizard
> > - protocol_jabber.patch : Modify the Jabber
protocol provider service
> > for the two new fields.
> > - jabber_plugin.patch : Main patch. The wizard
with rhe new features.
> > 
> > --
> > Regards.
> > Nicolas Grandclaude
> > 
> 
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
> 
-- 

(C) Matthew Rubenstein

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hi Matthew,

there's no such list for now. We've planned to make a
repository soon 
(issue:  238).

Regards,
Yana

Matthew Rubenstein wrote:
> 	Where is the list of S-C plugins available for
install?
> 
> 
> On Thu, 2007-05-31 at 12:41 +0200, Yana Stamcheva
wrote:
>> Hi Nicolas,
>>
>> I've finished revision of your plugin and have
committed your code. 
>> You've done some pretty good work! I've just made
some minor changes in 
>> order to make the plugin fit better to
sip-communicator code conventions.
>>
>> Here's the list of modifications:
>>
>> - I've removed the I18NStringJabberWizard class and
have replace it by a 
>> method getMnemonic in the Resources class.
>>
>> - In the JabberServerChooserDialog have moved the
TableModel from the 
>> init method to a private class. Within the
TableModel have also added a 
>> constructor, which loads the comments.xml file and
have changed the 
>> getValueAt method to access the DOM document
instead of opening the file 
>> each time.
>>
>> - Renamed the comments.xml to servercomments.xml.
>>
>> - Added some more comments and slightly changed
some label texts.
>>
>> - I've slightly reorganized some classes (moved the
constructor in the 
>> beginning of the class, changed the place of some
of the methods).
>>
>> - Added the RESOURCE and RESOURCE_PRIORITY
properties in the 
>> ProtocolProviderFactory.
>>
>> - In the ProtocolProviderServiceJabberImpl added a
check for null for 
>> accountResource before invoking the
connection.login(userID, password, 
>> accountResource). I've also moved the
presence.setPriority() to the 
>> OperationSetPersistentPresenceJabberImpl.
>>
>> Thanks for your great contribution!
>>
>> Yana
>>
>> Nicolas Grandclaude wrote:
>>> Hi,
>>>
>>> I work fot my student project (50 hours) on the
Jabber protocol
>>> implementation in SIP Communicator. My subject
was to add the creation
>>> of new account in SIP Communicator.
>>>
>>> I do it with the enhancement of the jabber
account registration plugin.
>>> I add a new button for new account in the
registration form on the
>>> model of the aim registration plugin. When we
click on this button, a
>>> new form appears with server name, new user id
and password field. A
>>> button "choose" is at the right of
the server field. It opens a new
>>> dialog with a JTable contains servers from
servers.xml of jabber.org
>>> (http://www.jabber.o
rg/servers.xml). This file is save on disk in the
>>> user home for prevent user or jabber.org
offline. When we valid the new
>>> account dialog, the account is created and the
field of the wizard are
>>> filled.
>>>
>>> Also, I add two new field in the Jabber account
wizard : ressource and
>>> priority. These fields are used by the Jabber
server when we are
>>> connected in two places in the same time. They
are saved in the sip
>>> communicator config file like other.
>>>
>>> Currently bug :
>>> - The wizard window size is often too small and
we can see the new
>>> button.
>>>
>>> I attach with the mail three patch files (they
applies on the CVS tree
>>> of today : 2007-05-28) :
>>> - build_xml.patch : Modify build.xml for add
smack with Jabber Wizard
>>> - protocol_jabber.patch : Modify the Jabber
protocol provider service
>>> for the two new fields.
>>> - jabber_plugin.patch : Main patch. The wizard
with rhe new features.
>>>
>>> --
>>> Regards.
>>> Nicolas Grandclaude
>>>
>>
------------------------------------------------------------
---------
>> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
>> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
>>

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net