rss4sc: new implementation using ROME

Ok Damian, but I have a problem building the project: ant
seems not to like the empty lines between instructions
into the manifest files...
("rss.provider.manifest.mf" and
"rssaccregwizz.manifest.mf" files)

Besides, that seems ok !!!

Can you precise me what you would like that I mention ?
(you wrote:
>Just a little tip about the distribution you have
provided. Please 
>provide and properties with comments for
accounts.properties.template - 
>used for tests. Everything else seems ok.)


Ciao.
Jean-Albert.


>Hi,
>
>I've just committed RSS protocol provider with some
minor changes like : 
>code formating, fix some javadoc conflicts
>and in ContactRssImpl changed converting Dates to String
and String to 
>Dates - now using SimpleDateFormat.
>Thats it for now  I've
already started to use it. Great 
>
>damencho




------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hello Jean-Albert,

Thank you for your contribution and for how reactive you've
been. Very 
nice code. The feature is really very useful! I've never
been using RSS 
that much before. Really nice!

I've been modifying some things over the last few days so I
am attaching 
a list of everything I changed (don't let this discourage
you though, 
it's still a great contribution!)

So, here goes:

In RssFeedReader.java:

* Renamded recupFlux() to retrieveFlow()
     - nothing but English in source code!
* Added an OperationFailedException to retrieveFlow()
     - we need to have some kind of indication if retrieving
a flow 
fails so that we could act accordingly (e.g. not add a
contact to the 
contact list)
* The reader should be created with a URL object and not an
unparsed string.
     - URL objects must be created as early as possible
(e.g. at the 
time a contact is added to the contact list) so that we
could parse and 
test the syntax of the URL and ignore the contact if we
encounter any 
problems.
* Made the sortItems() method private
     - seems that there's no one else using it.
* Made sortItems use Arrays.sort()
     - thought it would be better this way rather than let
it implement 
the sort itself. I've therefore also added a comparatator
class.
* ReReversed sort order for RSS posts.
     - given the way SC wokrs and what it is used for, the
user is most 
likely to only be seeing the last messages being printed
out. In the 
meantime, the msgs that a user would be most likely to be
looking for 
are the newest, so it would be better if they were printed
last.
* Removed calls to System.out.println()
     - we should be using
net.java.sip.communicator.util.Logger instead.

In ContactRssImpl:

* Store a reference of the source RSS url and RssFeedReader
     - did this so that
OperationSetBasicInstantMessagingRssImpl could 
then reuse them.

* Removed the getToken() method
     - seems no one was using it.

In OperationSetPersistentPresenceRssImpl:

* Removed the deliverAuthentication() method
     - seems like Gibberish residue so I decided to drop it.
I don't 
think we handle or need authorizations in RSS do we?

* Remove the createVolatileContact() method.
     - we don't really have that for RSS

* Remove the getNonPersistentGroup() method
     - unused

* Remove the findProviderForRssID() method
     - unused. (Gibberish residue?)

In OperationSetBasicInstantMessaging:

* Removed java.awt imports
     - unnecessary

* Removed the deliverMessage() method.
     - I guess this too was a residue from gibberish that we
don't need 
here.

* The sendInstantMessage() method was creating a
MessageDeliveredEvent 
instance that it was not using
     - the event instance is actually created by the 
fireMessageDelivered() method

In RssThread:

* Constructor shouldn't be calling start()
     - this is the responsibility of the one creating the
thread.

In RssTimerRefreshFeed:

* Do not use RssThred
     - All timer tasks are being run in a thread of their
own, created 
by the java.util.Timer. Hence, there's no need to be
executing a new thread

OperationSetTypingNotifications:

* Removed the class since we don't need typing notifications
for RSS.

OK, I guess that's all. In case you don't agree with any of
the changes, 
please let me know.

Oh, and btw, I've ack-ed your effort on the team and
contributors page.

Thanks for all your efforts!
Emil

Jean-Albert Vescovo wrote:
> Ok Damian, but I have a problem building the project:
ant seems not
> to like the empty lines between instructions into the
manifest
> files... ("rss.provider.manifest.mf" and
"rssaccregwizz.manifest.mf"
> files)
> 
> Besides, that seems ok !!!
> 
> Can you precise me what you would like that I mention ?
(you wrote:
>> Just a little tip about the distribution you have
provided. Please
>>  provide and properties with comments for
>> accounts.properties.template - used for tests.
Everything else
>> seems ok.)
> 
> 
> Ciao. Jean-Albert.
> 
> 
>> Hi,
>> 
>> I've just committed RSS protocol provider with some
minor changes
>> like : code formating, fix some javadoc conflicts
and in
>> ContactRssImpl changed converting Dates to String
and String to 
>> Dates - now using SimpleDateFormat. Thats it for
now 
I've
>> already started to use it. Great 
>> 
>> damencho
> 
> 
> 
> 
>
------------------------------------------------------------
---------
>  To unsubscribe, e-mail:
> dev-unsubscribesip-communicator.dev.java.net For
additional
> commands, e-mail: dev-helpsip-communicator.dev.java.net
> 
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hey JD,

Thanks for the note!

I've just applied it.

Cheers
Emil

JD wrote:
> 
> 
> 2007/6/1, Jean-Albert Vescovo <ja.vescovofree.fr 
> <mailto:ja.vescovofree.fr>>:
> 
>     Ok Damian, but I have a problem building the
project: ant seems not
>     to like the empty lines between instructions
>     into the manifest files...
>     ("rss.provider.manifest.mf" and
"rssaccregwizz.manifest.mf" files)
> 
>     Besides, that seems ok !!!
> 
> 
> Yes, problem with blank lines in the two manifest files
 quoted  above.
> I tried the plugin, and it actually works fine.
> Good work !
> 
> Just a note:
> 
> in the wizard when we're asked to create an rss account
:
> "Press next to creat your RSS account..."  
create spelled "create" 
> would be better, wouldn't be ? (spellcheck plugin which
I'm working on, 
> is turning me into a spell paranoiac, sorry )
> 
> here is the correction :
> 
>
net.java.sip.communicator.plugin.rssaccregwizz.FirstWizardPa
ge.java   
> line 75
> ======================================================
>     private JLabel creatingAccountLabel =
> 
>         new JLabel("Press next to create your RSS
account...");
> 
> 
> 
> ======================================================
> 
> Anyway excellent work, I'm already using it
> C ya later guys
> 
> Jean-Daniel
> 
>     Can you precise me what you would like that I
mention ?
>     (you wrote:
>      >Just a little tip about the distribution you
have provided. Please
>      >provide and properties with comments for
>     accounts.properties.template -
>      >used for tests. Everything else seems ok.)
> 
> 
>     Ciao.
>     Jean-Albert.
> 
> 
>      >Hi,
>      >
>      >I've just committed RSS protocol provider with
some minor changes
>     like :
>      >code formating, fix some javadoc conflicts
>      >and in ContactRssImpl changed converting Dates
to String and
>     String to
>      >Dates - now using SimpleDateFormat.
>      >Thats it for now  I've
already started to use it. Great 
>      >
>      >damencho
> 
> 
> 
> 
>    
------------------------------------------------------------
---------
>     To unsubscribe, e-mail:
>     dev-unsubscribesip-communicator.dev.java.net
>     <mailto:dev-unsubscribesip-communicator.dev.java.net>
>     For additional commands, e-mail:
>     dev-helpsip-communicator.dev.java.net
>     <mailto:dev-helpsip-communicator.dev.java.net>
> 
> 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Very well, I'm happy to discover that I helped you to find a
new toy !
No problem with your modifications - you know, I'm not a
good 
programmer, but in fact I try just to become a passable
network manager !
And as I said it in my little report, many things in my code
were 
remainders from Gibberish , so...

I've just a few problems now:
- under MSWindows, the last installer proposed for
downloading proposes 
RSS support, but after it's installed it, RSS doesn't
work...?
- I have still the problem to compile the project under
Netbeans because 
the two manifest files that I mentioned in a previous
message are still
with blank lines between two other lines...

For finish, I am glad to have been able to take part in this
project by 
giving you a small blow of hand !
...and I could work my English: thanks !

Yours sincerely,

Jean-Albert


Emil Ivov a écrit :
> Hello Jean-Albert,
>
> Thank you for your contribution and for how reactive
you've been. Very 
> nice code. The feature is really very useful! I've
never been using 
> RSS that much before. Really nice!
>
> I've been modifying some things over the last few days
so I am 
> attaching a list of everything I changed (don't let
this discourage 
> you though, it's still a great contribution!)
>
> So, here goes:
>
> In RssFeedReader.java:
>
> * Renamded recupFlux() to retrieveFlow()
>     - nothing but English in source code!
> * Added an OperationFailedException to retrieveFlow()
>     - we need to have some kind of indication if
retrieving a flow 
> fails so that we could act accordingly (e.g. not add a
contact to the 
> contact list)
> * The reader should be created with a URL object and
not an unparsed 
> string.
>     - URL objects must be created as early as possible
(e.g. at the 
> time a contact is added to the contact list) so that we
could parse 
> and test the syntax of the URL and ignore the contact
if we encounter 
> any problems.
> * Made the sortItems() method private
>     - seems that there's no one else using it.
> * Made sortItems use Arrays.sort()
>     - thought it would be better this way rather than
let it implement 
> the sort itself. I've therefore also added a
comparatator class.
> * ReReversed sort order for RSS posts.
>     - given the way SC wokrs and what it is used for,
the user is most 
> likely to only be seeing the last messages being
printed out. In the 
> meantime, the msgs that a user would be most likely to
be looking for 
> are the newest, so it would be better if they were
printed last.
> * Removed calls to System.out.println()
>     - we should be using
net.java.sip.communicator.util.Logger instead.
>
> In ContactRssImpl:
>
> * Store a reference of the source RSS url and
RssFeedReader
>     - did this so that
OperationSetBasicInstantMessagingRssImpl could 
> then reuse them.
>
> * Removed the getToken() method
>     - seems no one was using it.
>
> In OperationSetPersistentPresenceRssImpl:
>
> * Removed the deliverAuthentication() method
>     - seems like Gibberish residue so I decided to drop
it. I don't 
> think we handle or need authorizations in RSS do we?
>
> * Remove the createVolatileContact() method.
>     - we don't really have that for RSS
>
> * Remove the getNonPersistentGroup() method
>     - unused
>
> * Remove the findProviderForRssID() method
>     - unused. (Gibberish residue?)
>
> In OperationSetBasicInstantMessaging:
>
> * Removed java.awt imports
>     - unnecessary
>
> * Removed the deliverMessage() method.
>     - I guess this too was a residue from gibberish
that we don't need 
> here.
>
> * The sendInstantMessage() method was creating a
MessageDeliveredEvent 
> instance that it was not using
>     - the event instance is actually created by the 
> fireMessageDelivered() method
>
> In RssThread:
>
> * Constructor shouldn't be calling start()
>     - this is the responsibility of the one creating
the thread.
>
> In RssTimerRefreshFeed:
>
> * Do not use RssThred
>     - All timer tasks are being run in a thread of
their own, created 
> by the java.util.Timer. Hence, there's no need to be
executing a new 
> thread
>
> OperationSetTypingNotifications:
>
> * Removed the class since we don't need typing
notifications for RSS.
>
> OK, I guess that's all. In case you don't agree with
any of the 
> changes, please let me know.
>
> Oh, and btw, I've ack-ed your effort on the team and
contributors page.
>
> Thanks for all your efforts!
> Emil
>
> Jean-Albert Vescovo wrote:
>> Ok Damian, but I have a problem building the
project: ant seems not
>> to like the empty lines between instructions into
the manifest
>> files... ("rss.provider.manifest.mf" and
"rssaccregwizz.manifest.mf"
>> files)
>>
>> Besides, that seems ok !!!
>>
>> Can you precise me what you would like that I
mention ? (you wrote:
>>> Just a little tip about the distribution you
have provided. Please
>>>  provide and properties with comments for
>>> accounts.properties.template - used for tests.
Everything else
>>> seems ok.)
>>
>>
>> Ciao. Jean-Albert.
>>
>>
>>> Hi,
>>>
>>> I've just committed RSS protocol provider with
some minor changes
>>> like : code formating, fix some javadoc
conflicts and in
>>> ContactRssImpl changed converting Dates to
String and String to 
>>> Dates - now using SimpleDateFormat. Thats it
for now  I've
>>> already started to use it. Great 
>>>
>>> damencho
>>
>>
>>
>>
>>
------------------------------------------------------------
---------
>>  To unsubscribe, e-mail:
>> dev-unsubscribesip-communicator.dev.java.net For additional
>> commands, e-mail: dev-helpsip-communicator.dev.java.net
>>
>>
>
>

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net