HEITZ JM - DTMF Implementation (poor draft)

Hello,

I noticed some people need a SIP DTMF Implementation. I
wrote a little
one some time ago (see the attached files), which implements
the DTMF
OpSet. As far as I remember, I mostly took the code of the
Sip Basic
Telephony OpSet implementation and adapted it for DTMF
sending - so have
a look at the telephony opset implementation.

My files should only be considered as drafts - I currently
have no time
to develop this code further, so that it fits
"SC standards". I'm sorry for the poor quality of
my files (they weren't
designed to be published in this state, initially), but I
think it might
help those who want to implement this functionnality.

The important files are the ProtocolProviderService and the
OpSet
implementation - for the PPS, just search "DTMF"
to see the little
section I added (beware, this PPS is for sure old, so just
take the
section, and not the whole file).

The other files form a package which should provide (again,
as far as I
remember) a little panel that let the user enter a DTMF.

Tonight, I've just added some comments to the OpSet
implementation
before sending this mail, but I wasn't able to try to make
it compile
(sorry, I just noticed Eclipse is broken on my computer).

That's said, feel free to adapt, modify, and improve the
code I've written.

Jean-Marie



------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hey, Jean-Marie,

Did christmas arrive early?

Judging from the demand we've been seeing lately on this
list, I think
you ought to be getting quite a few presents this year ;).
Thank you for
this pleasant surprise.

I've committed your patch and ack-ed your effort on the Team
and
Contributors page.

I know that Yana has almost finished the UI part for
DTMF-ing so I've
only committed the implementation of the operation set.

Here's the list of modifications that I've applied before
committing.
Let me know if any of them are bothering you:

* I've added our default license header
* Added your name as an author
* Applied default project code formatting rules
* Removed unnecessary imports
* Resolved some javadoc conflicts
* Removed the code terminating a transaction in the
processTimeout()
method (if we get in that method, this means that the
transaction is
terminated.)
* Removed static constructor method
* Added a test making sure that a dialog is not terminated
before
sending dtmf tone inside it.

And that's it.

Thanks again Jean-Marie!

Emil

HEITZ Jean-Marie wrote:
> Hello,
> 
> I noticed some people need a SIP DTMF Implementation. I
wrote a little
> one some time ago (see the attached files), which
implements the DTMF
> OpSet. As far as I remember, I mostly took the code of
the Sip Basic
> Telephony OpSet implementation and adapted it for DTMF
sending - so have
> a look at the telephony opset implementation.
> 
> My files should only be considered as drafts - I
currently have no time
> to develop this code further, so that it fits
> "SC standards". I'm sorry for the poor
quality of my files (they weren't
> designed to be published in this state, initially), but
I think it might
> help those who want to implement this functionnality.
> 
> The important files are the ProtocolProviderService and
the OpSet
> implementation - for the PPS, just search
"DTMF" to see the little
> section I added (beware, this PPS is for sure old, so
just take the
> section, and not the whole file).
> 
> The other files form a package which should provide
(again, as far as I
> remember) a little panel that let the user enter a
DTMF.
> 
> Tonight, I've just added some comments to the OpSet
implementation
> before sending this mail, but I wasn't able to try to
make it compile
> (sorry, I just noticed Eclipse is broken on my
computer).
> 
> That's said, feel free to adapt, modify, and improve
the code I've written.
> 
> Jean-Marie
> 
> 
> 




------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net