Hi Emil,
I've separated them in my last mail to dev, please check it
out. 
Thanks,
Su
On 7/12/07, Emil Ivov <emcho emcho.com> wrote:
> Hey Su,
>
> Thanks for submitting!
>
> I just noticed that you have included all class
dependencies in the
> patch. Do you think you could take them out of the
patch and submit them
> apart (e.g. in a jar of their own)? This would make the
patch easier to
> review.
>
> Thanks
> Emil
>
> Bing Su wrote:
> > Hi Romain / Jean,
> >
> > Long time no talk
> > I was just about to send my code for mid-term
evaluation and now I see
> > your mail.
> >
> > The file attached with this mail is a
"minimal" working patch for SC-SRTP.
> > I created this patch using eclipse with latest cvs
source (07/09/2007).
> > And did a "two sip communicator test".
There is a flag (usingSRTP) in
> > CallSessionImpl controlling whether shall we
> > use SRTP encryption. If both sides are on or off,
then we will get
> > correct voice.
> > If one side is on and the other side is off, then
we will hear only
> > noisy sounds.
> >
> > Because we don't have a key management protocol
yet, I can't test the
> > impl with other clients. And the master key / salt
is hard coded in
> > the program.
> >
> > I used jdk1.4.2 for compilation but it failed at
somewhere else, so I
> > used jdk1.6.0.
> >
> > Bouncycastle's jar file is included in the patch.
It's manifest file
> > is very big and will cause wired class not found
exception. So I
> > removed it from the jar file.
> >
> > I've encountered some other wired class not found
problems with
> > eclipse, but rebuilding it with ant has fixed
them.
> >
> > Because I think the code is still unstable, I
wrote no java comments.
> > They will be added later when the code is stable
enough.
> >
> > Still there are many places need to be polished
and many work need to done.
> > For now, I think we are on the correct way of SRTP
implementation.
> >
> > Some of my code is derived from Werner's ccRtp.
Many thanks to him.
> >
> > If you have any question, please let me know.
> >
> > Thanks,
> > Su
> >
> > On 7/9/07, Romain KUNTZ <r.kuntzgmail.com> wrote:
> >> Hi Su,
> >>
> >> How are you doing?
> >> Today starts the GSoC middle term evaluations.
Note that the
> >> evaluation is not a goal in itself, but we
would need to see what you
> >> have achieved so far to check that we are in
the right way in the
> >> project. Could you submit us your code (as a
patch or a tarball) as
> >> soon as possible, so that we can start your
evaluation?
> >>
> >> Also, do not forget to fill your midterm
survey as explained in
> >> http://groups.google.com/group/google-summer-o
f-code-announce/web/
> >> midterm-survey-information
> >>
> >> Cheers,
> >> Romain & Jean
> >>
> >>
> >>
> >>
------------------------------------------------------------
------------
> >>
> >>
------------------------------------------------------------
---------
> >> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
> >> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
>
>
------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net
|