Re: jUnit tests for RSS - _very_ preliminary version

Hi Mihai,

Thanks for your patch.

I have skimmed all your test code and compared it with the
one found in 
Gibberish,
as a base. You have done a good work and (of course) all
tests (6) passed.

This said, I have some remarks.

    1 - In TestAccountInstallation, as you have used an 
accountProperties, you might
use the following code :
    rssProviderFactory.installAccount(
               
accountProperties.get(ProtocolProviderFactory.USER_ID),
                accountProperties);
instead of
    rssProviderFactory.installAccount("RSS",
accountProperties);

    Another thing I noticed is that the rssaccregwizz
accepts to install 
only one
RSS account. Is that limitation enforced by the protocol
provider ? In 
other words,
if we try to install two (different) RSS accounts will it
always fails ?

    2 - For which kind of tests do you plan to use the feed

server/factory (rather than using online
feeds) ?

    3 - I noticed that a few method lacks of javadoc
comments, but since 
you haven't finished,
I guess it is temporary ;)

As you stated that this patch is a preview version, I won't
commit it, 
waiting for your latest
version, in case you plan to bring substantial modifications
soon. This 
said, the accomplished work is
very good and if upcoming tests are written in the same way,
I think we 
could use your test code verbatim.

Thanks for the time.

Regards
    Sympho

Mihai Balan a écrit :
> Hello everybody,
> I'm working for some time on the test package for the
RSS protocol.
> Right now it's in a _very_ eraly stage, meaning that
there are only
> four, simple test cases implemented (very similar to
those in the
> Gibberish SLICK) and a very simple server that can/will
be used later
> on.
> Right now testing some of the features of the current
implementation
> isn't quite problems as the protocol still has some
holes in it
> (namely online/offline switching/detection for both
remote contacts
> (aka feeds) and user account).
> It's the first time I write unit tests, so any
suggestion is more than
> welcome. I won't be able to check my mail for a week or
so, but I look
> forward for your impressions.
>
> Thanks in advance for your time,
> Mihai
>
> PS: To actually get to run the test one should also
alter the
> testing.properties file and add
RssProtocolProviderServiceLick to the
> list of tests.
>
------------------------------------------------------------
------------
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
> For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hi! I got following exception when trying with java 1.6. It
seems an
incompatibility between Java 1.6 (or 1.5) and the JMF on
Windows. It there
any possibility for a workaround or do I have to use java
1.4.2?

Regards, thomas

16:20:05.859 SCHWERWIEGEND:
impl.media.CallSessionImpl.controllerUpdate().1836 The
following error was
reported while starting a
playerjavax.media.ResourceUnavailableEvent[source=com.sun.me
dia.content.unkn
own.Handler1c30dfa,message=Failed to realize: input media not
supported:
h263/rtp video]
Exception in thread "JMF thread:
com.sun.media.PlaybackEnginea7563d (
prefetchThread)" java.lang.IllegalArgumentException:
Requested value
7.9588003 exceeds allowable maximum value 6.0206.
	at
javax.sound.sampled.FloatControl.setValue(FloatControl.java:
178)
	at
com.sun.media.sound.DirectAudioDevice$DirectDL$Gain.setValue
(DirectAudioDevi
ce.java:833)
	at
com.sun.media.renderer.audio.device.JavaSoundOutput.setGain(
JavaSoundOutput.
java:157)
	at
com.sun.media.renderer.audio.AudioRenderer.initDevice(AudioR
enderer.java:294
)
	at
com.sun.media.renderer.audio.JavaSoundRenderer.initDevice(Ja
vaSoundRenderer.
java:125)
	at
com.sun.media.renderer.audio.JavaSoundRenderer.open(JavaSoun
dRenderer.java:9
1)
	at
com.sun.media.BasicRendererModule.doPrefetch(BasicRendererMo
dule.java:157)
	at
com.sun.media.BasicTrackControl.prefetchTrack(BasicTrackCont
rol.java:98)
	at
com.sun.media.PlaybackEngine.doPrefetch1(PlaybackEngine.java
:592)
	at
com.sun.media.PlaybackEngine.doPrefetch(PlaybackEngine.java:
547)
	at
com.sun.media.PrefetchWorkThread.process(BasicController.jav
a:1430)
	at
com.sun.media.StateTransitionWorkThread.run(BasicController.
java:1339)

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net

Hi!
When I try to communicate with other clients, or, in this
case with a
softswitch gateway to POTS, the voice quality is terrible.
There is a lot of
echo and a damaged audio stream. The guys from the
softswitch said, that it
seems, that SC ignores the "packetization time",
which is set by the
softswitch. It works with the other tested softphones like
Xlite or Wengo,
so this seems an SC issure, or one of the used stack. It
this known, is
there a workaround?

Regards, thomas

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesip-communicator.dev.java.net
For additional commands, e-mail: dev-helpsip-communicator.dev.java.net