|
List Info
Thread: minical 0.1 patchfile
|
|
| minical 0.1 patchfile |
|
2006-07-05 16:25:05 |
|
| Jeremy,
I am not sure if its appropriate to post patches to the list, so help me out here....
Is that correct Ted/John.T ?
Thanks, -Priscilla On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote: OK here it is.....
I am not sure if its appropriate to post patches to the list, so help me out here....
ths zip file contains images -- extract to your images subdirectory on webapp. the .diff file is for SVN
What is here
minical drawing in scooby --you can navigate months and select days etc... I tired to make the interface conform as strictly to chandler as possible. -- you can move minical around the screen-- this is for the designers-- screen snap where you want it and we can stick it there.
what is not here -- mini cal doe not update the main calendar -- that is for the main scooby team to do. I hope mincal will act as a sharp stick for the dev team to settle on a architecture for these components and views. -- busy bars. mostly because I do not have an efficient means of getting the data. I would prefer an array of "scores" the length of the number of months currently shown. I.e. one score (from 0.0 to 1.0 per day) I don't need to know about actual events. --this is still not a dojo widget, although it uses dojo libraries for substantially all external operations (i.e. dojo.late, .event etc..) --its interface should be compatable with dojo. --does not use dojo topics for updateing-- it uses an alternate framework until dev team decides what to do --minical updates the Pref object (via cal_main, which I consdered the controller) when changing selected day. Cal main currently does not expose methods to get or set selected day that can update external views, so I added them. There is a catch-- surrently the methods update the Prefs store, but do not update the main calendar. I leave it to matthew to hook the getter and setter to cal_main internal data model.
anyway have fun
Jeremy
|
| minical 0.1 patchfile |
|
2006-07-05 18:45:27 |
|
| Yes, the generally accepted mechanism is to do an svn diff > patchfile to generate a patch file and than attach that patch file to a bug that matches up with what you are doing.
The one hole I have found in this is that svndiff will not pick up new files. I haven't yet figured out what we should do about new file submissions.
Ted, so you have any thoughts on this?
--> towns
On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote: Jeremy,
I am not sure if its appropriate to post patches to the list, so help me out here....
Is that correct Ted/John.T ?
Thanks, -Priscilla On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote: OK here it is.....
I am not sure if its appropriate to post patches to the list, so help me out here....
ths zip file contains images -- extract to your images subdirectory on webapp. the .diff file is for SVN
What is here
minical drawing in scooby --you can navigate months and select days etc... I tired to make the interface conform as strictly to chandler as possible. -- you can move minical around the screen-- this is for the designers-- screen snap where you want it and we can stick it there.
what is not here -- mini cal doe not update the main calendar -- that is for the main scooby team to do. I hope mincal will act as a sharp stick for the dev team to settle on a architecture for these components and views. -- busy bars. mostly because I do not have an efficient means of getting the data. I would prefer an array of "scores" the length of the number of months currently shown. I.e. one score (from 0.0 to 1.0 per day) I don't need to know about actual events. --this is still not a dojo widget, although it uses dojo libraries for substantially all external operations (i.e. dojo.late, .event etc..) --its interface should be compatable with dojo. --does not use dojo topics for updateing-- it uses an alternate framework until dev team decides what to do --minical updates the Pref object (via cal_main, which I consdered the controller) when changing selected day. Cal main currently does not expose methods to get or set selected day that can update external views, so I added them. There is a catch-- surrently the methods update the Prefs store, but do not update the main calendar. I leave it to matthew to hook the getter and setter to cal_main internal data model.
anyway have fun
Jeremy
_______________________________________________ scooby-dev mailing list |
| minical 0.1 patchfile |
|
2006-07-05 18:45:27 |
|
| Yes, the generally accepted mechanism is to do an svn diff > patchfile to generate a patch file and than attach that patch file to a bug that matches up with what you are doing.
The one hole I have found in this is that svndiff will not pick up new files. I haven't yet figured out what we should do about new file submissions.
Ted, so you have any thoughts on this?
--> towns
On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote: Jeremy,
I am not sure if its appropriate to post patches to the list, so help me out here....
Is that correct Ted/John.T ?
Thanks, -Priscilla On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote: OK here it is.....
I am not sure if its appropriate to post patches to the list, so help me out here....
ths zip file contains images -- extract to your images subdirectory on webapp. the .diff file is for SVN
What is here
minical drawing in scooby --you can navigate months and select days etc... I tired to make the interface conform as strictly to chandler as possible. -- you can move minical around the screen-- this is for the designers-- screen snap where you want it and we can stick it there.
what is not here -- mini cal doe not update the main calendar -- that is for the main scooby team to do. I hope mincal will act as a sharp stick for the dev team to settle on a architecture for these components and views. -- busy bars. mostly because I do not have an efficient means of getting the data. I would prefer an array of "scores" the length of the number of months currently shown. I.e. one score (from 0.0 to 1.0 per day) I don't need to know about actual events. --this is still not a dojo widget, although it uses dojo libraries for substantially all external operations (i.e. dojo.late, .event etc..) --its interface should be compatable with dojo. --does not use dojo topics for updateing-- it uses an alternate framework until dev team decides what to do --minical updates the Pref object (via cal_main, which I consdered the controller) when changing selected day. Cal main currently does not expose methods to get or set selected day that can update external views, so I added them. There is a catch-- surrently the methods update the Prefs store, but do not update the main calendar. I leave it to matthew to hook the getter and setter to cal_main internal data model.
anyway have fun
Jeremy
_______________________________________________ scooby-dev mailing list |
| minical 0.1 patchfile |
|
2006-07-05 19:09:24 |
|
Here are our current guidelines for submitting patches to the desktop client: <http://wiki.osafoundation.org/bin/view/Projects/PatchLifeCycle>. This generally (except for the particular SVN repository) the procedure that we should be following for patches. I will go make sure that this page gets linked to from the appropriate scooby documentation.
I'd add a few comments to that.
In addition to creating a bug and attaching the patch, you should send a message to the Scooby dev list when you are submitting a major piece of functionality, including the bug number. In the ideal case, the development of the minical would have been done somewhat publicly -- Jeremy would have asked questions about how things in Scooby worked, having explained his objective of building a minical. The scooby-devs would have responded and there would have been a public conversation about the development of this feature. The creation of the bug carrying the patch would have been a natural outcome of this conversation. The reason for the mail message is to ensure that everyone who might be interested in the features has a chance to add themselves to the Cc: list of the bug.
The use of the bug is important because it provides a place to communicate about the status of the patch. When a patch comes in, the lifecycle on the commiter side should be to review the patch, possibly asking for changes or corrections. Once the patch is in good shape, it is normally the job of the committer to integrate the patch into the source tree. Again, the bug is the channel for the committer to indicate her status on integrating the patch. When the patch is integrated, the bug will be closed and everyone who cares (by being on the Cc: list) will be notified.
Ted
On Jul 5, 2006, at 11:45 AM, John Townsend wrote:
Yes, the generally accepted mechanism is to do an svn diff > patchfile to generate a patch file and than attach that patch file to a bug that matches up with what you are doing.
The one hole I have found in this is that svndiff will not pick up new files. I haven't yet figured out what we should do about new file submissions.
Ted, so you have any thoughts on this?
--> towns
On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote: Jeremy,
I am not sure if its appropriate to post patches to the list, so help me out here....
Is that correct Ted/John.T ?
Thanks, -Priscilla On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote: OK here it is.....
I am not sure if its appropriate to post patches to the list, so help me out here....
ths zip file contains images -- extract to your images subdirectory on webapp. the .diff file is for SVN
What is here
minical drawing in scooby --you can navigate months and select days etc... I tired to make the interface conform as strictly to chandler as possible. -- you can move minical around the screen-- this is for the designers-- screen snap where you want it and we can stick it there.
what is not here -- mini cal doe not update the main calendar -- that is for the main scooby team to do. I hope mincal will act as a sharp stick for the dev team to settle on a architecture for these components and views. -- busy bars. mostly because I do not have an efficient means of getting the data. I would prefer an array of "scores" the length of the number of months currently shown. I.e. one score (from 0.0 to 1.0 per day) I don't need to know about actual events. --this is still not a dojo widget, although it uses dojo libraries for substantially all external operations (i.e. dojo.late, .event etc..) --its interface should be compatable with dojo. --does not use dojo topics for updateing-- it uses an alternate framework until dev team decides what to do --minical updates the Pref object (via cal_main, which I consdered the controller) when changing selected day. Cal main currently does not expose methods to get or set selected day that can update external views, so I added them. There is a catch-- surrently the methods update the Prefs store, but do not update the main calendar. I leave it to matthew to hook the getter and setter to cal_main internal data model.
anyway have fun
Jeremy
_______________________________________________ scooby-dev mailing list _______________________________________________ scooby-dev mailing list
|
| minical 0.1 patchfile |
|
2006-07-05 19:09:24 |
|
Here are our current guidelines for submitting patches to the desktop client: <http://wiki.osafoundation.org/bin/view/Projects/PatchLifeCycle>. This generally (except for the particular SVN repository) the procedure that we should be following for patches. I will go make sure that this page gets linked to from the appropriate scooby documentation.
I'd add a few comments to that.
In addition to creating a bug and attaching the patch, you should send a message to the Scooby dev list when you are submitting a major piece of functionality, including the bug number. In the ideal case, the development of the minical would have been done somewhat publicly -- Jeremy would have asked questions about how things in Scooby worked, having explained his objective of building a minical. The scooby-devs would have responded and there would have been a public conversation about the development of this feature. The creation of the bug carrying the patch would have been a natural outcome of this conversation. The reason for the mail message is to ensure that everyone who might be interested in the features has a chance to add themselves to the Cc: list of the bug.
The use of the bug is important because it provides a place to communicate about the status of the patch. When a patch comes in, the lifecycle on the commiter side should be to review the patch, possibly asking for changes or corrections. Once the patch is in good shape, it is normally the job of the committer to integrate the patch into the source tree. Again, the bug is the channel for the committer to indicate her status on integrating the patch. When the patch is integrated, the bug will be closed and everyone who cares (by being on the Cc: list) will be notified.
Ted
On Jul 5, 2006, at 11:45 AM, John Townsend wrote:
Yes, the generally accepted mechanism is to do an svn diff > patchfile to generate a patch file and than attach that patch file to a bug that matches up with what you are doing.
The one hole I have found in this is that svndiff will not pick up new files. I haven't yet figured out what we should do about new file submissions.
Ted, so you have any thoughts on this?
--> towns
On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote: Jeremy,
I am not sure if its appropriate to post patches to the list, so help me out here....
Is that correct Ted/John.T ?
Thanks, -Priscilla On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote: OK here it is.....
I am not sure if its appropriate to post patches to the list, so help me out here....
ths zip file contains images -- extract to your images subdirectory on webapp. the .diff file is for SVN
What is here
minical drawing in scooby --you can navigate months and select days etc... I tired to make the interface conform as strictly to chandler as possible. -- you can move minical around the screen-- this is for the designers-- screen snap where you want it and we can stick it there.
what is not here -- mini cal doe not update the main calendar -- that is for the main scooby team to do. I hope mincal will act as a sharp stick for the dev team to settle on a architecture for these components and views. -- busy bars. mostly because I do not have an efficient means of getting the data. I would prefer an array of "scores" the length of the number of months currently shown. I.e. one score (from 0.0 to 1.0 per day) I don't need to know about actual events. --this is still not a dojo widget, although it uses dojo libraries for substantially all external operations (i.e. dojo.late, .event etc..) --its interface should be compatable with dojo. --does not use dojo topics for updateing-- it uses an alternate framework until dev team decides what to do --minical updates the Pref object (via cal_main, which I consdered the controller) when changing selected day. Cal main currently does not expose methods to get or set selected day that can update external views, so I added them. There is a catch-- surrently the methods update the Prefs store, but do not update the main calendar. I leave it to matthew to hook the getter and setter to cal_main internal data model.
anyway have fun
Jeremy
_______________________________________________ scooby-dev mailing list _______________________________________________ scooby-dev mailing list
|
| minical 0.1 patchfile |
|
2006-07-05 19:16:23 |
Actually if you use the gui tool in windows, it appears to
include new
files in the diff, so long as you do a pre-commit add.
Quoting John Townsend <johntownsend mac.com>:
> Yes, the generally accepted mechanism is to do an svn
diff > patchfile
> to generate a patch file and than attach that patch
file to a bug that
> matches up with what you are doing.
>
> The one hole I have found in this is that svndiff will
not pick up new
> files. I haven't yet figured out what we should do
about new file
> submissions.
>
> Ted, so you have any thoughts on this?
>
> --> towns
>
> On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote:
>
>> Jeremy,
>>
>>> I am not sure if its appropriate to post
patches to the list, so
>>> help me out here....
>>
>> Please go ahead and update the bug #4641 (https://
>> bugzilla.osafoundation.org/show_bug.cgi?id=4641).
In future, I
>> think you can go ahead and attach the patch to the
bug, that is
>> until you have commiter's right to check it into
the tree.
>>
>> Is that correct Ted/John.T ?
>>
>> Thanks, -Priscilla
>>
>> On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote:
>>
>>> OK here it is.....
>>>
>>> I am not sure if its appropriate to post
patches to the list, so
>>> help me out here....
>>>
>>> ths zip file contains images -- extract to your
images
>>> subdirectory on webapp.
>>> the .diff file is for SVN
>>>
>>> What is here
>>>
>>> minical drawing in scooby
>>> --you can navigate months and select days
etc... I tired to make
>>> the interface conform as strictly to chandler
as possible.
>>> -- you can move minical around the screen--
this is for the
>>> designers-- screen snap where you want it and
we can stick it there.
>>>
>>> what is not here
>>> -- mini cal doe not update the main calendar --
that is for the
>>> main scooby team to do. I hope mincal will act
as a sharp stick
>>> for the dev team to settle on a architecture
for these components
>>> and views.
>>> -- busy bars. mostly because I do not have an
efficient means of
>>> getting the data. I would prefer an array of
"scores" the length
>>> of the number of months currently shown. I.e.
one score (from 0.0
>>> to 1.0 per day) I don't need to know about
actual events.
>>> --this is still not a dojo widget, although it
uses dojo libraries
>>> for substantially all external operations
(i.e. dojo.late,
>>> .event etc..)
>>> --its interface should be compatable with dojo.
>>> --does not use dojo topics for updateing-- it
uses an alternate
>>> framework until dev team decides what to do
>>> --minical updates the Pref object (via
cal_main, which I consdered
>>> the controller) when changing selected day.
Cal main currently
>>> does not expose methods to get or set selected
day that can update
>>> external views, so I added them. There is a
catch-- surrently
>>> the methods update the Prefs store, but do
not update the main
>>> calendar. I leave it to matthew to hook the
getter and setter to
>>> cal_main internal data model.
>>>
>>> anyway have fun
>>>
>>> Jeremy
>>
>> _______________________________________________
>> scooby-dev mailing list
>> scooby-devlists.osafoundation.org
>> http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
_______________________________________________
scooby-dev mailing list
scooby-devlists.osafoundation.org
http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
|
|
| minical 0.1 patchfile |
|
2006-07-05 19:16:23 |
Actually if you use the gui tool in windows, it appears to
include new
files in the diff, so long as you do a pre-commit add.
Quoting John Townsend <johntownsendmac.com>:
> Yes, the generally accepted mechanism is to do an svn
diff > patchfile
> to generate a patch file and than attach that patch
file to a bug that
> matches up with what you are doing.
>
> The one hole I have found in this is that svndiff will
not pick up new
> files. I haven't yet figured out what we should do
about new file
> submissions.
>
> Ted, so you have any thoughts on this?
>
> --> towns
>
> On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote:
>
>> Jeremy,
>>
>>> I am not sure if its appropriate to post
patches to the list, so
>>> help me out here....
>>
>> Please go ahead and update the bug #4641 (https://
>> bugzilla.osafoundation.org/show_bug.cgi?id=4641).
In future, I
>> think you can go ahead and attach the patch to the
bug, that is
>> until you have commiter's right to check it into
the tree.
>>
>> Is that correct Ted/John.T ?
>>
>> Thanks, -Priscilla
>>
>> On Jul 4, 2006, at 1:06 PM, Jeremy Epstein wrote:
>>
>>> OK here it is.....
>>>
>>> I am not sure if its appropriate to post
patches to the list, so
>>> help me out here....
>>>
>>> ths zip file contains images -- extract to your
images
>>> subdirectory on webapp.
>>> the .diff file is for SVN
>>>
>>> What is here
>>>
>>> minical drawing in scooby
>>> --you can navigate months and select days
etc... I tired to make
>>> the interface conform as strictly to chandler
as possible.
>>> -- you can move minical around the screen--
this is for the
>>> designers-- screen snap where you want it and
we can stick it there.
>>>
>>> what is not here
>>> -- mini cal doe not update the main calendar --
that is for the
>>> main scooby team to do. I hope mincal will act
as a sharp stick
>>> for the dev team to settle on a architecture
for these components
>>> and views.
>>> -- busy bars. mostly because I do not have an
efficient means of
>>> getting the data. I would prefer an array of
"scores" the length
>>> of the number of months currently shown. I.e.
one score (from 0.0
>>> to 1.0 per day) I don't need to know about
actual events.
>>> --this is still not a dojo widget, although it
uses dojo libraries
>>> for substantially all external operations
(i.e. dojo.late,
>>> .event etc..)
>>> --its interface should be compatable with dojo.
>>> --does not use dojo topics for updateing-- it
uses an alternate
>>> framework until dev team decides what to do
>>> --minical updates the Pref object (via
cal_main, which I consdered
>>> the controller) when changing selected day.
Cal main currently
>>> does not expose methods to get or set selected
day that can update
>>> external views, so I added them. There is a
catch-- surrently
>>> the methods update the Prefs store, but do
not update the main
>>> calendar. I leave it to matthew to hook the
getter and setter to
>>> cal_main internal data model.
>>>
>>> anyway have fun
>>>
>>> Jeremy
>>
>> _______________________________________________
>> scooby-dev mailing list
>> scooby-devlists.osafoundation.org
>> http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
_______________________________________________
scooby-dev mailing list
scooby-devlists.osafoundation.org
http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
|
|
| minical 0.1 patchfile |
|
2006-07-05 20:45:45 |
Yeah, the Eclipse tool deals with new files as well.
On Jul 5, 2006, at 12:16 PM, eggfreeeggfree.net wrote:
> Actually if you use the gui tool in windows, it appears
to include
> new files in the diff, so long as you do a pre-commit
add.
>
>
> Quoting John Townsend <johntownsendmac.com>:
>
>> Yes, the generally accepted mechanism is to do an
svn diff >
>> patchfile
>> to generate a patch file and than attach that patch
file to a bug
>> that
>> matches up with what you are doing.
>>
>> The one hole I have found in this is that svndiff
will not pick
>> up new
>> files. I haven't yet figured out what we should do
about new file
>> submissions.
>>
>> Ted, so you have any thoughts on this?
>>
>> --> towns
>>
>> On Jul 5, 2006, at 9:25 AM, Priscilla Chung wrote:
>>
>>> Jeremy,
>>>
>>>> I am not sure if its appropriate to post
patches to the list,
>>>> so help me out here....
>>>
>>> Please go ahead and update the bug #4641
(https://
>>>
bugzilla.osafoundation.org/show_bug.cgi?id=4641). In future,
I
>>> think you can go ahead and attach the patch to
the bug, that is
>>> until you have commiter's right to check it
into the tree.
>>>
>>> Is that correct Ted/John.T ?
>>>
>>> Thanks, -Priscilla
>>>
>>> On Jul 4, 2006, at 1:06 PM, Jeremy Epstein
wrote:
>>>
>>>> OK here it is.....
>>>>
>>>> I am not sure if its appropriate to post
patches to the list,
>>>> so help me out here....
>>>>
>>>> ths zip file contains images -- extract to
your images
>>>> subdirectory on webapp.
>>>> the .diff file is for SVN
>>>>
>>>> What is here
>>>>
>>>> minical drawing in scooby
>>>> --you can navigate months and select days
etc... I tired to
>>>> make the interface conform as strictly to
chandler as possible.
>>>> -- you can move minical around the screen--
this is for the
>>>> designers-- screen snap where you want it
and we can stick it
>>>> there.
>>>>
>>>> what is not here
>>>> -- mini cal doe not update the main
calendar -- that is for
>>>> the main scooby team to do. I hope mincal
will act as a sharp
>>>> stick for the dev team to settle on a
architecture for these
>>>> components and views.
>>>> -- busy bars. mostly because I do not have
an efficient means
>>>> of getting the data. I would prefer an
array of "scores" the
>>>> length of the number of months currently
shown. I.e. one score
>>>> (from 0.0 to 1.0 per day) I don't need
to know about actual
>>>> events.
>>>> --this is still not a dojo widget, although
it uses dojo
>>>> libraries for substantially all external
operations (i.e.
>>>> dojo.late, .event etc..)
>>>> --its interface should be compatable with
dojo.
>>>> --does not use dojo topics for updateing--
it uses an
>>>> alternate framework until dev team
decides what to do
>>>> --minical updates the Pref object (via
cal_main, which I
>>>> consdered the controller) when changing
selected day. Cal main
>>>> currently does not expose methods to get
or set selected day
>>>> that can update external views, so I
added them. There is a
>>>> catch-- surrently the methods update the
Prefs store, but do
>>>> not update the main calendar. I leave it
to matthew to hook
>>>> the getter and setter to cal_main
internal data model.
>>>>
>>>> anyway have fun
>>>>
>>>> Jeremy
>>>
>>> _______________________________________________
>>> scooby-dev mailing list
>>> scooby-devlists.osafoundation.org
>>> http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
>
>
> _______________________________________________
> scooby-dev mailing list
> scooby-devlists.osafoundation.org
> http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
_______________________________________________
scooby-dev mailing list
scooby-devlists.osafoundation.org
http://lists.osafoundation.org/cgi-bin/mailman
/listinfo/scooby-dev
|
|
[1-8]
|
|