Segmentation fault with PHP>=5.2.1

Hi,

with the current HEAD version of SimpleTest and PHP 5.2.1
(verified with 
5.2.2) I'm getting a segmentation fault under Windows (Linux
not tested) 
when using UnitTestCase::expectException(). The problem does
not occur 
with PHP5.2.0.

I tracked the problem down to line 388 in unit_tester.php:
$queue->expectException($expected, $message .
$this->getAssertionLine());

If I change this code to
$assertionLine = $this->getAssertionLine();
$queue->expectException($expected, $message .
$assertionLine);

everything works fine again. I'm not sure where this comes
from and I 
think its a bit weird that this little change fixes the
problem. Does 
anyone else had such a problem?

Regards,
Frank

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

This reminds me of all the "reference" problem we
used to have when the 
4.4 branch came out. I'll test it tomorrow on my Windows box
and apply 
your suggestion if I can reproduce it. The fix is pretty
easy anyway...

At least on Mac OS X, it doesn't break !

	Perrick



Frank Kleine wrote:
> Hi,
> 
> with the current HEAD version of SimpleTest and PHP
5.2.1 (verified with 
> 5.2.2) I'm getting a segmentation fault under Windows
(Linux not tested) 
> when using UnitTestCase::expectException(). The problem
does not occur 
> with PHP5.2.0.
> 
> I tracked the problem down to line 388 in
unit_tester.php:
> $queue->expectException($expected, $message .
$this->getAssertionLine());
> 
> If I change this code to
> $assertionLine = $this->getAssertionLine();
> $queue->expectException($expected, $message .
$assertionLine);
> 
> everything works fine again. I'm not sure where this
comes from and I 
> think its a bit weird that this little change fixes the
problem. Does 
> anyone else had such a problem?
> 
> Regards,
> Frank
> 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2
express and take
> control of your XML. No limits. Just data. Click to get
it now.
> http://sourcefor
ge.net/powerbar/db2/
> _______________________________________________
> Simpletest-support mailing list
> Simpletest-supportlists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/simp
letest-support
> 
> 

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Hi Frank...

Frank Kleine wrote:
> with the current HEAD version of SimpleTest and PHP
5.2.1 (verified with 
> 5.2.2) I'm getting a segmentation fault under Windows
(Linux not tested) 
> when using UnitTestCase::expectException(). The problem
does not occur 
> with PHP5.2.0.
>  r
> I tracked the problem down to line 388 in
unit_tester.php:
> $queue->expectException($expected, $message .
$this->getAssertionLine());
>
> If I change this code to
> $assertionLine = $this->getAssertionLine();
> $queue->expectException($expected, $message .
$assertionLine);
>
> everything works fine again. I'm not sure where this
comes from and I 
> think its a bit weird that this little change fixes the
problem. Does 
> anyone else had such a problem?

Very weird...  This sounds like a particular issue with PHP,
so I would 
definitely open a bug report with them.  The fix seems
simple enough on 
our end though, so I'm all for getting it fixed, I just hope
we can get 
PHP to address the underlying issue there.

Have you tested with PHP 5.2.3 or any of the 5.1.x branch? 
I'm just 
curious when this got introduced into the internals.

-T

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Hi Travis,

> Very weird...  This sounds like a particular issue with
PHP, so I would 
> definitely open a bug report with them.  The fix seems
simple enough on 
> our end though, so I'm all for getting it fixed, I just
hope we can get 
> PHP to address the underlying issue there.

For the moment I hesitate to open a bug because I do not
have the 
possibility to provide any deeper insights and I bet they
will ask for a 
back trace which I can not provide at the moment. 

> Have you tested with PHP 5.2.3 or any of the 5.1.x
branch?  I'm just 
> curious when this got introduced into the internals.

I did not test with 5.2.3, I will see if I can do this next
weekend. I 
can not test with 5.1.x because the stuff to test requires
5.2.x. 
However it worked well with 5.2.0, so I think the regression
must have 
been introduced with 5.2.1.

Regards,
Frank


------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Frank Kleine wrote:
> For the moment I hesitate to open a bug because I do
not have the 
> possibility to provide any deeper insights and I bet
they will ask for a 
> back trace which I can not provide at the moment. 

Could we know a little more about your configuration? PHP
has a very
good track record when it comes to segfaults: the one time I
had this
problem (and it was very nearly the exactly same issue:
nested function
calls causing problems), Zend Optimizer was the root.

Regardless, if unrolling the declaration fixes the problem,
it should be
done.

- --
 Edward Z. Yang                        GnuPG: 0x869C48DA
 HTML Purifier  <htmlpurifier.org>  Anti-XSS HTML
Filter
 [[ 3FA8 E9A9 7385 B691 A6FC B3CB A933 BE7D 869C 48DA ]]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFGewabqTO+fYacSNoRAsmIAJwJCynenNaVfNbngcPDwxBFaf+AcgCe
PRYj
hCf1z3Sl7e3as9TTGvTrhW8=
=NzlX
-----END PGP SIGNATURE-----

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

I tried to reproduce your problem and didn't manage to. Do
you have a 
failing test case I could use. And by the way don't hesitate
to open a 
bug report.

http://sourceforge.net/tracker/?group_id=76550&
;atid=547455

Yours,
	Perrick



Frank Kleine wrote:
> Hi,
> 
> with the current HEAD version of SimpleTest and PHP
5.2.1 (verified with 
> 5.2.2) I'm getting a segmentation fault under Windows
(Linux not tested) 
> when using UnitTestCase::expectException(). The problem
does not occur 
> with PHP5.2.0.
> 
> I tracked the problem down to line 388 in
unit_tester.php:
> $queue->expectException($expected, $message .
$this->getAssertionLine());
> 
> If I change this code to
> $assertionLine = $this->getAssertionLine();
> $queue->expectException($expected, $message .
$assertionLine);
> 
> everything works fine again. I'm not sure where this
comes from and I 
> think its a bit weird that this little change fixes the
problem. Does 
> anyone else had such a problem?
> 
> Regards,
> Frank
> 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2
express and take
> control of your XML. No limits. Just data. Click to get
it now.
> http://sourcefor
ge.net/powerbar/db2/
> _______________________________________________
> Simpletest-support mailing list
> Simpletest-supportlists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/simp
letest-support
> 
> 

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Hi Perrick,

today I tested with 5.2.3, everything seems to work fine
with it.

If you are still interested in investigating I can try to
create a 
reproducable test case from our sources - I guess you are
not that much 
interested in diving into the Stubbles (test) source code.


Regards,
Frank


Perrick Penet schrieb:
> I tried to reproduce your problem and didn't manage to.
Do you have a 
> failing test case I could use. And by the way don't
hesitate to open a 
> bug report.
> 
> http://sourceforge.net/tracker/?group_id=76550&
;atid=547455
> 
> Yours,
> 	Perrick
> 
> 
> 
> Frank Kleine wrote:
>> Hi,
>>
>> with the current HEAD version of SimpleTest and PHP
5.2.1 (verified with 
>> 5.2.2) I'm getting a segmentation fault under
Windows (Linux not tested) 
>> when using UnitTestCase::expectException(). The
problem does not occur 
>> with PHP5.2.0.
>>
>> I tracked the problem down to line 388 in
unit_tester.php:
>> $queue->expectException($expected, $message .
$this->getAssertionLine());
>>
>> If I change this code to
>> $assertionLine = $this->getAssertionLine();
>> $queue->expectException($expected, $message .
$assertionLine);
>>
>> everything works fine again. I'm not sure where
this comes from and I 
>> think its a bit weird that this little change fixes
the problem. Does 
>> anyone else had such a problem?
>>
>> Regards,
>> Frank


------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Hi Franck,

I did try some tests with 5.2.0, 5.2.1, 5.2.2 and 5.2.3 (on
Windows) and 
everything was fine. If you cand send me a failing test
case, we can add 
it to our test suite and make sure it doesn't come back
bitting us later 
on. So yes I am still interested !

Yours,
	Perrick


Frank Kleine wrote:
> Hi Perrick,
> 
> today I tested with 5.2.3, everything seems to work
fine with it.
> 
> If you are still interested in investigating I can try
to create a 
> reproducable test case from our sources - I guess you
are not that much 
> interested in diving into the Stubbles (test) source
code. 
> 
> Regards,
> Frank
> 
> 
> Perrick Penet schrieb:
>> I tried to reproduce your problem and didn't manage
to. Do you have a 
>> failing test case I could use. And by the way don't
hesitate to open a 
>> bug report.
>>
>> http://sourceforge.net/tracker/?group_id=76550&
;atid=547455
>>
>> Yours,
>> 	Perrick
>>
>>
>>
>> Frank Kleine wrote:
>>> Hi,
>>>
>>> with the current HEAD version of SimpleTest and
PHP 5.2.1 (verified with 
>>> 5.2.2) I'm getting a segmentation fault under
Windows (Linux not tested) 
>>> when using UnitTestCase::expectException(). The
problem does not occur 
>>> with PHP5.2.0.
>>>
>>> I tracked the problem down to line 388 in
unit_tester.php:
>>> $queue->expectException($expected, $message
. $this->getAssertionLine());
>>>
>>> If I change this code to
>>> $assertionLine = $this->getAssertionLine();
>>> $queue->expectException($expected, $message
. $assertionLine);
>>>
>>> everything works fine again. I'm not sure where
this comes from and I 
>>> think its a bit weird that this little change
fixes the problem. Does 
>>> anyone else had such a problem?
>>>
>>> Regards,
>>> Frank
> 
> 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2
express and take
> control of your XML. No limits. Just data. Click to get
it now.
> http://sourcefor
ge.net/powerbar/db2/
> _______________________________________________
> Simpletest-support mailing list
> Simpletest-supportlists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/simp
letest-support
> 
> 

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Hi Perrick,

today I tracked the problem down to Zend Optimizer. I had it
enabled in 
5.2.1 and 5.2.2, but not in 5.2.3 which is the reason why it
worked 
there again. I stumbled upon this today by using the tools
advised in
<http://blog.thepimp.net/index.php/post/2007/06/10/
debug-pack-or-how-to-generate-backtrack-on-windows-without-c
ompiling>

If I disable Zend Optimizer everything works fine with 5.2.1
and 5.2.2 
as well. You should be able to reproduce this with
SimpleTests 
test/browser_test.php, it shows the same problems when Zend
Optimizer is 
enabled: works well without it, segfaults when enabled.

Regards,
Frank


> 
> Hi Franck,
> 
> I did try some tests with 5.2.0, 5.2.1, 5.2.2 and 5.2.3
(on Windows) and
> everything was fine. If you cand send me a failing test
case, we can add
> it to our test suite and make sure it doesn't come back
bitting us later
> on. So yes I am still interested !
> 
> Yours,
> Perrick
>
> 
> > Hi Perrick,
> > 
> > today I tested with 5.2.3, everything seems to
work fine with it.
> > 
> > If you are still interested in investigating I can
try to create a 
> > reproducable test case from our sources - I guess
you are not that much 
> > interested in diving into the Stubbles (test)
source code. 







------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support

Thanks for taking the time to track it down. I should be
able to 
reproduce the bug now and commit your solution next time I'm
at home 
(with my Windows box).

Yours,
	Perrick

PS : did you try to submit a bug report to Zend ?


Frank Kleine wrote:
> Hi Perrick,
> 
> today I tracked the problem down to Zend Optimizer. I
had it enabled in 
> 5.2.1 and 5.2.2, but not in 5.2.3 which is the reason
why it worked 
> there again. I stumbled upon this today by using the
tools advised in
> <http://blog.thepimp.net/index.php/post/2007/06/10/
debug-pack-or-how-to-generate-backtrack-on-windows-without-c
ompiling>
> 
> If I disable Zend Optimizer everything works fine with
5.2.1 and 5.2.2 
> as well. You should be able to reproduce this with
SimpleTests 
> test/browser_test.php, it shows the same problems when
Zend Optimizer is 
> enabled: works well without it, segfaults when
enabled.
> 
> Regards,
> Frank
> 
> 
>> Hi Franck,
>>
>> I did try some tests with 5.2.0, 5.2.1, 5.2.2 and
5.2.3 (on Windows) and
>> everything was fine. If you cand send me a failing
test case, we can add
>> it to our test suite and make sure it doesn't come
back bitting us later
>> on. So yes I am still interested !
>>
>> Yours,
>> Perrick
>>
>>
>>> Hi Perrick,
>>>
>>> today I tested with 5.2.3, everything seems to
work fine with it.
>>>
>>> If you are still interested in investigating I
can try to create a 
>>> reproducable test case from our sources - I
guess you are not that much 
>>> interested in diving into the Stubbles (test)
source code. 
> 
> 
> 
> 
> 
> 
> 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2
express and take
> control of your XML. No limits. Just data. Click to get
it now.
> http://sourcefor
ge.net/powerbar/db2/
> _______________________________________________
> Simpletest-support mailing list
> Simpletest-supportlists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/simp
letest-support
> 
> 

------------------------------------------------------------
-------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and
take
control of your XML. No limits. Just data. Click to get it
now.
http://sourcefor
ge.net/powerbar/db2/
_______________________________________________
Simpletest-support mailing list
Simpletest-supportlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/simp
letest-support