Anything outstanding for 2.15?

Are there any outstanding patches or other updates for 2.15
that weren't 
in 2.14a?

A





_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

> Are there any outstanding patches or other updates for
2.15 
> that weren't in 2.14a?

I have a few notes on Template::Stash. I still see that
regexp /^[_.]/ for
identifying "private" hash items (in 'item'
hash vmethod, '_dotop' and
'_assign' methods) - I think three times is enough for
moving it to a
separate method.

Also, some vmethods (list 'sort' and 'nsort', hash
'item') still use complex
constructs to access hash items. Few month ago I proposed to
use _dotop in
all that cases for the uniformity of code (however, this may
decrease
perfomance when sorting list of hashes).

And, anyway Schwartzian Transform (converting to lowercase)
is redundant for
'nsort' vmethod 

If you consider this notes to be reasonable, I can make
patches for all this
things when I have a bit time 



By the way, I've tried 2.14a on FreeBSD 6.0-RELEASE-p7
(amd64) and FreeBSD
4.9-RELEASE-p23 (i386) - all test passed ok.

All tests successful, 2 tests skipped.
Files=79, Tests=2589, 24 wallclock secs (10.03 cusr +  1.47
csys = 11.50
CPU)

All tests successful, 2 tests skipped.
Files=79, Tests=2589, 38 wallclock secs (10.19 cusr +  0.93
csys = 11.12
CPU)

(Skipped tests are t/autoform and t/pod)


-- 
Sergey Martynoff


_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

Here are two things I just found today:

I believe this documentation needs to be removed from the
DBI.pm plugin/docs now, correct?
-------------------
IMPORTANT NOTE: the XS Stash (Template::Stash::XS) does not
currently support access to tied hashes.....
-------------------



In Plugins/Table.pm (cvs line 220):
------------------------
if ($item =~ /^data|size|nrows|ncols|overlap|pad$/) {

My guess is that this should be:
if ($item =~ /^(?:data|size|nrows|ncols|overlap|pad)$/) {
------------------------




For previous "pending" patches I'd still like
to see the check for backrefs when doing search and replace
as noted in our previous thread. As I noted, that check is
simple and results in a huge increase in speed when not
using backrefs. I'm fine with foregoing the other
"less readable" changes like removing subs, but
I feel that this simple one is worth it.
http://template-toolkit.org/pipermail/t
emplates/2006-February/008359.html

For the backref check only it looks like we would just add
this between lines 85 and 86 in CVS:
-------------------------------------------------------
my $replace_has_backref;
while ($replace =~ m/(\\*) \$\d+/gx) {
  if (length($1 || '') % 2 == 0) {
    $replace_has_backref = 1;
    last;
  }
}

if (!$replace_has_backref) {
  if ($global) {
    $text =~ s/$pattern/$replace/g;
  } else {
    $text =~ s/$pattern/$replace/;
  }
  return $text;
}
-------------------------------------------------------


There was also a CHOMP patch being discussed I believe too.
Thread:
http://template-toolkit.org/piperm
ail/templates/2006-February/thread.html#8354


-- Josh

Andy Wardley wrote:
> Are there any outstanding patches or other updates for
2.15 that weren't 
> in 2.14a?
> 
> A
> 
> 
> 
> 
> 
> _______________________________________________
> templates mailing list
> templatestemplate-toolkit.org
> http://lists.template-toolkit.org/mailman/listinfo/t
emplates


_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

Josh (or Andy),

> I believe this documentation needs to be removed from
the DBI.pm 
> plugin/docs now, correct?
> -------------------
> IMPORTANT NOTE: the XS Stash (Template::Stash::XS) does
not currently 
> support access to tied hashes.....
> -------------------

Refresh my memory ... is this only no longer true in 2.15,
or has it been untrue for a while now?  Or, to rephrase in a

slightly more clearer fashion, what is the first version
that does (or will) support tied hashes in XS?

Thanx.


		-- Buddy

_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

This was resolved for 2.15.

-- Josh

Buddy Burden wrote:
> Josh (or Andy),
> 
>> I believe this documentation needs to be removed
from the DBI.pm 
>> plugin/docs now, correct?
>> -------------------
>> IMPORTANT NOTE: the XS Stash (Template::Stash::XS)
does not currently 
>> support access to tied hashes.....
>> -------------------
> 
> Refresh my memory ... is this only no longer true in
2.15, or has it 
> been untrue for a while now?  Or, to rephrase in a
slightly more clearer 
> fashion, what is the first version that does (or will)
support tied 
> hashes in XS?
> 
> Thanx.
> 
> 
>         -- Buddy


_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

Josh Rosenbaum wrote:
> I believe this documentation needs to be removed from
the DBI.pm 
> plugin/docs now, correct?
> -------------------
> IMPORTANT NOTE: the XS Stash (Template::Stash::XS) does
not currently 
> support access to tied hashes.....
> -------------------

Yes, although the DBI plugin will no longer be part of the
core from 
2.15 onwards.  It'll be in a separate Template-DBI
distribution.  For 
now this will just contain the DBI plugin unless anyone else
has a DBI 
related plugin, provider or other code they want to
contribute.

> In Plugins/Table.pm (cvs line 220):
> ------------------------
> if ($item =~ /^data|size|nrows|ncols|overlap|pad$/) {
> 
> My guess is that this should be:
> if ($item =~ /^(?:data|size|nrows|ncols|overlap|pad)$/)
{
> ------------------------

Fixed, thanks.

> For previous "pending" patches I'd still
like to see the check for 
> backrefs when doing search and replace as noted in our
previous thread. 

Done.  Like so:

         if ($replace =~ /\$\d+/) {
             # the slow way with backrefs
         }
         else {
             # the fast way without backrefs
         }
         return $text;

I opted for a simple \$\d+ regex to look for backrefs in
the replacement 
  string.  Although it's not totally thorough in that it
could 
inadvertently match against "\\$2", it'll
still work correctly, albeit 
slower.  I figured that was an acceptable trade-off for
simplicity of 
code given that it's an uncommon edge case.

> There was also a CHOMP patch being discussed I believe
too.

That's done too.

Cheers
A




_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

On 5/12/06, Andy Wardley <abwwardley.org> wrote:
> Are there any outstanding patches or other updates for
2.15 that weren't
> in 2.14a?

Hi Andy,

This little patch to Template::Plugin::Image never received
any
feedback, and I don't see it in CVS.  It should be safe to
apply:

http://www.mail
-archive.com/templatestemplate-toolkit.org/msg07728.html

Cheers,

Cees

_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates

Cees Hek wrote:
> This little patch to Template::Plugin::Image never
received any
> feedback, and I don't see it in CVS.  It should be
safe to apply:
> 
> http://www.mail
-archive.com/templatestemplate-toolkit.org/msg07728.html

Got it, thanks!

A

_______________________________________________
templates mailing list
templatestemplate-toolkit.org
http://lists.template-toolkit.org/mailman/listinfo/t
emplates