List Info

Thread: patch: namespace corruption in xmlParseBalancedChunkMemoryRecover




patch: namespace corruption in xmlParseBalancedChunkMemoryRecover
user name
2006-09-11 19:29:23
Can someone commit this patch for me? I am away and can't
commit to CVS 
right now.

Patch fixes tree corruption when a doc is passed to 
xmlParseBalancedChunkMemoryRecover and something using the
XML namespace 
is parsed from the chunk. This patch makes sure that the XML
namespapce 
has already been created on the origional document and sets
oldNS from 
the origional document on newDoc. This way the XML namespace
from the 
origional document will be used on the tree being created,
so when tree 
is added to origional document and newDoc is destroyed the
namespace 
will be valid.
Currently once newDoc is free'd (causing the XML namespace
created just 
for that document to be freed), its use in the new tree is
now garbage.

rans the tests and they were fine.

Rob
_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xmlgnome.org
http://mai
l.gnome.org/mailman/listinfo/xml
patch: namespace corruption in xmlParseBalancedChunkMemoryRecover
user name
2006-09-12 01:43:13
On Mon, Sep 11, 2006 at 03:29:23PM -0400, Rob Richards
wrote:
> Can someone commit this patch for me? I am away and
can't commit to CVS 
> right now.

  Well I'm on the road too, the first one back commits it


> Patch fixes tree corruption when a doc is passed to 
> xmlParseBalancedChunkMemoryRecover and something using
the XML namespace 
> is parsed from the chunk. This patch makes sure that
the XML namespapce 
> has already been created on the origional document and
sets oldNS from 
> the origional document on newDoc. This way the XML
namespace from the 
> origional document will be used on the tree being
created, so when tree 
> is added to origional document and newDoc is destroyed
the namespace 
> will be valid.
> Currently once newDoc is free'd (causing the XML
namespace created just 
> for that document to be freed), its use in the new tree
is now garbage.
> 
> rans the tests and they were fine.

  Very few tests actually cover this kind of cut and paste
operations,
hopefully you have them better covered within PHP regression
suite.

Daniel


-- 
Red Hat Virtualization group http://redhat.com/v
irtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillardredhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ |
Rpmfind RPM search engine  http://rpmfind.net/
_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xmlgnome.org
http://mai
l.gnome.org/mailman/listinfo/xml
[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )