xmlTextConcat and comment nodes

Should xmlTextConcat be able to be used with comment nodes
or is it 
really necessary to handle these manually? Currently it is
limited to 
text and cdata, although I see no reason to not work with
comments. In 
the DOM world, this function should work, but just checking
no one 
objects to this change.

Rob

_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xmlgnome.org
http://mai
l.gnome.org/mailman/listinfo/xml

On Thu, Sep 14, 2006 at 09:17:05AM -0400, Rob Richards
wrote:
> Should xmlTextConcat be able to be used with comment
nodes or is it 
> really necessary to handle these manually? Currently it
is limited to 
> text and cdata, although I see no reason to not work
with comments. In 
> the DOM world, this function should work, but just
checking no one 
> objects to this change.

  Yup sure, and while you are at it, add support for PI that
should be
exactly the same, can probably reuse the same code.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/v
irtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillardredhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ |
Rpmfind RPM search engine  http://rpmfind.net/
_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xmlgnome.org
http://mai
l.gnome.org/mailman/listinfo/xml

On Thu, Sep 14, 2006 at 09:17:05AM -0400, Rob Richards
wrote:
> Should xmlTextConcat be able to be used with comment
nodes or is it 
> really necessary to handle these manually? Currently it
is limited to 
> text and cdata, although I see no reason to not work
with comments. In 
> the DOM world, this function should work, but just
checking no one 
> objects to this change.

  Yup sure, and while you are at it, add support for PI that
should be
exactly the same, can probably reuse the same code.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/v
irtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillardredhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ |
Rpmfind RPM search engine  http://rpmfind.net/
_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xmlgnome.org
http://mai
l.gnome.org/mailman/listinfo/xml