List Info

Thread: Change to blame.php




Change to blame.php
user name
2007-08-23 14:40:17
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I did a small change to the blame.php, I think it looks much
better, if
the name does not get repeated. I also did some changes to
the BlueGrey
template, to make use of the line coloring and make the
output much
smaller (if you're interested in the changes I can also send
them)

See
http://svn.orig
o.ethz.ch/wsvn/origo/core/trunk/nodes/core/node_core.e?op=bl
ame&rev=0&sc=0
for an example

Regards,

Patrick

The new development platform
http://origo.ethz.ch


- --- blame.php   (revision 604)
+++ blame.php   (working copy)
 -113,21
+113,18 
                $url = $config->getURL($rep, $parent,
'dir');
                $listing[$index]['revision'] = "<a
id="l$index-rev"
class="blame-revision"
href="$rev=$revision&amp;sc=1">$revi
sion</a>";
                $seen_rev[$revision] = 1;
+               $row_class = ($row_class == 'light') ?
'dark' : 'light';
+               $listing[$index]['author'] = $author;
             }
             else
             {
                $listing[$index]['revision'] =
"";
+               $listing[$index]['author'] = '';
             }

- -            if ($last_rev <> $revision)
- -            {
- -               $row_class = ($row_class == 'light') ?
'dark' : 'light';
- -            }
- -
             $listing[$index]['row_class'] = $row_class;
             $last_rev = $revision;

- -            $listing[$index]['author'] = $author;

             $line = rtrim(fgets($file));
             if ($ent) $line = replaceEntities($line,
$rep);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFGzeKhaA/ofYi4EMoRAvevAJ4vjCSuKw+SQMiNMGxME5UFqq/B0ACf
Tf4Z
qZ+kprd9wSZ3YQKCSN9Y7J8=
=L0aP
-----END PGP SIGNATURE-----

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribewebsvn.tigris.org
For additional commands, e-mail: dev-helpwebsvn.tigris.org


Re: Change to blame.php
user name
2007-08-25 06:06:33
Hi Patrick,

thank you for your patch, i just applied it to the current
trunk. It is 
more consistent with the revision number now. I also updated
the 
BlueGrey template to use the line coloring. If you have
other changes, 
please let me know.

Regards,
Sebastian

Patrick Ruckstuhl schrieb:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> I did a small change to the blame.php, I think it looks
much better, if
> the name does not get repeated. I also did some changes
to the BlueGrey
> template, to make use of the line coloring and make the
output much
> smaller (if you're interested in the changes I can also
send them)
> 
> See
> http://svn.orig
o.ethz.ch/wsvn/origo/core/trunk/nodes/core/node_core.e?op=bl
ame&rev=0&sc=0
> for an example
> 
> Regards,
> 
> Patrick
> 
> The new development platform
> http://origo.ethz.ch
> 
> 
> - --- blame.php   (revision 604)
> +++ blame.php   (working copy)
>  -113,21 +113,18 
>                 $url = $config->getURL($rep,
$parent, 'dir');
>                 $listing[$index]['revision'] =
"<a id="l$index-rev"
> class="blame-revision"
>
href="$rev=$revision&amp;sc=1">$revi
sion</a>";
>                 $seen_rev[$revision] = 1;
> +               $row_class = ($row_class == 'light') ?
'dark' : 'light';
> +               $listing[$index]['author'] = $author;
>              }
>              else
>              {
>                 $listing[$index]['revision'] =
"";
> +               $listing[$index]['author'] = '';
>              }
> 
> - -            if ($last_rev <> $revision)
> - -            {
> - -               $row_class = ($row_class == 'light')
? 'dark' : 'light';
> - -            }
> - -
>              $listing[$index]['row_class'] =
$row_class;
>              $last_rev = $revision;
> 
> - -            $listing[$index]['author'] = $author;
> 
>              $line = rtrim(fgets($file));
>              if ($ent) $line = replaceEntities($line,
$rep);
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

> 
>
iD8DBQFGzeKhaA/ofYi4EMoRAvevAJ4vjCSuKw+SQMiNMGxME5UFqq/B0ACf
Tf4Z
> qZ+kprd9wSZ3YQKCSN9Y7J8=
> =L0aP
> -----END PGP SIGNATURE-----

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribewebsvn.tigris.org
For additional commands, e-mail: dev-helpwebsvn.tigris.org


Re: Change to blame.php
user name
2007-08-25 10:23:44
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

what I also changed is to remove the classes and also all
unneded
whitespaces from the td in the blame.php as the size was
just to big
with some files (before all the changes, the generated file
for a big
blame was around 3mb, now it's down to 1mb)

The line looks now like that:

[websvn-startlisting]
<tr
class="[websvn:row_class]"><td>[websvn:li
neno]</td><td>[websvn:revision]</td><td
>[websvn:author]</td><td>[websvn:line]</td
></tr>
[websvn-endlisting]

Thanks and Regards,

Patrick

> thank you for your patch, i just applied it to the
current trunk. It is
> more consistent with the revision number now. I also
updated the
> BlueGrey template to use the line coloring. If you have
other changes,
> please let me know.
> 
> Regards,
> Sebastian
> 
> Patrick Ruckstuhl schrieb:
> Hi,
> 
> I did a small change to the blame.php, I think it looks
much better, if
> the name does not get repeated. I also did some changes
to the BlueGrey
> template, to make use of the line coloring and make the
output much
> smaller (if you're interested in the changes I can also
send them)
> 
> See
> http://svn.orig
o.ethz.ch/wsvn/origo/core/trunk/nodes/core/node_core.e?op=bl
ame&rev=0&sc=0
> 
> for an example
> 
> Regards,
> 
> Patrick
> 
> The new development platform
> http://origo.ethz.ch
> 
> 
> --- blame.php   (revision 604)
> +++ blame.php   (working copy)
>  -113,21 +113,18 
>                 $url = $config->getURL($rep,
$parent, 'dir');
>                 $listing[$index]['revision'] =
"<a id="l$index-rev"
> class="blame-revision"
>
href="$rev=$revision&amp;sc=1">$revi
sion</a>";
>                 $seen_rev[$revision] = 1;
> +               $row_class = ($row_class == 'light') ?
'dark' : 'light';
> +               $listing[$index]['author'] = $author;
>              }
>              else
>              {
>                 $listing[$index]['revision'] =
"";
> +               $listing[$index]['author'] = '';
>              }
> 
> -            if ($last_rev <> $revision)
> -            {
> -               $row_class = ($row_class == 'light') ?
'dark' :
> 'light';
> -            }
> -
>              $listing[$index]['row_class'] =
$row_class;
>              $last_rev = $revision;
> 
> -            $listing[$index]['author'] = $author;
> 
>              $line = rtrim(fgets($file));
>              if ($ent) $line = replaceEntities($line,
$rep);

>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribewebsvn.tigris.org
> For additional commands, e-mail: dev-helpwebsvn.tigris.org


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


iD8DBQFG0EmAaA/ofYi4EMoRAiDUAJ95NbDa9ZDFKO7/27dRusibuMuDgACg
r3uL
XwozKu0225U7OWWgxyLiuuA=
=F0B6
-----END PGP SIGNATURE-----

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribewebsvn.tigris.org
For additional commands, e-mail: dev-helpwebsvn.tigris.org


[1-3]

about | contact  Other archives ( Real Estate discussion Medical topics )