What happened to the enabled_popup method?

What happened to the enabled_popup method?  I have been
using it quite
effectively up through 1081 and in 1084 it is gone.  Was
this replaced
by a better more robust method, or is there a preferred
method to
replace this functionality?  I know Watir is being changed
to add new
features, and fix bugs (all of which I greatly appreciate),
but if
something is going to be cut without replacement can you
give us a
little heads up please, or at leased give a deprecated
message?

Thanks, 

____________________
Mark L. Cain
LMIT - E*STARS(r) ~ Lead Test Engineer 
1981 Snyder, MSIN: G3-62, Richland, WA 99354
Mark_CainRL.gov
509.376.5458
"It's better to be careful 100 times than to get
killed once." ~ Mark
Twain"
_______________________________________________
Wtr-general mailing list
Wtr-generalrubyforge.org
htt
p://rubyforge.org/mailman/listinfo/wtr-general

Mark,

  It's still available, but in the watir/contrib directory.
In order
to use it, add
require 'watir/contrib/enabled_popup'
to your scripts. This is still a development version and so
there will
be some bumps along the way. Sorry about the confusion,
I'll try to
make sure changes are documented along the way to the next
release.

-Charley

On 9/18/06, Cain, Mark <Mark_Cainrl.gov> wrote:
> What happened to the enabled_popup method?  I have been
using it quite
> effectively up through 1081 and in 1084 it is gone. 
Was this replaced
> by a better more robust method, or is there a preferred
method to
> replace this functionality?  I know Watir is being
changed to add new
> features, and fix bugs (all of which I greatly
appreciate), but if
> something is going to be cut without replacement can
you give us a
> little heads up please, or at leased give a deprecated
message?
>
> Thanks,
>
> ____________________
> Mark L. Cain
> LMIT - E*STARS(r) ~ Lead Test Engineer
> 1981 Snyder, MSIN: G3-62, Richland, WA 99354
> Mark_CainRL.gov
> 509.376.5458
> "It's better to be careful 100 times than to get
killed once." ~ Mark
> Twain"
> _______________________________________________
> Wtr-general mailing list
> Wtr-generalrubyforge.org
> htt
p://rubyforge.org/mailman/listinfo/wtr-general
>
_______________________________________________
Wtr-general mailing list
Wtr-generalrubyforge.org
htt
p://rubyforge.org/mailman/listinfo/wtr-general

This change was documented in the commit log.
http://svn.openqa.org/fisheye/changelog/watir?c
s=1083&csize=3

Anyone who is tracking trunk should be watching the commit
log to be 
notified of these kinds of changes.
h
ttp://svn.openqa.org/fisheye/changelog/watir/trunk

There is an RSS link on this page that you can subscribe to.
That's what 
i do.

Bret


_______________________________________________
Wtr-general mailing list
Wtr-generalrubyforge.org
htt
p://rubyforge.org/mailman/listinfo/wtr-general

Charley Baker wrote:
> Mark,
>
>   It's still available, but in the watir/contrib
directory. In order
> to use it, add
> require 'watir/contrib/enabled_popup'
> to your scripts. This is still a development version
and so there will
> be some bumps along the way. Sorry about the confusion,
I'll try to
> make sure changes are documented along the way to the
next release.
>
> -Charley
>   
As the author of the enabled_popup() method I'd like to
argue that it 
remain in the main Watir code.  The enabled_popup call will
give you the 
window handle of ANY type of popup, so it is very useful
when a page may 
or may not open a popup window, and the user doesn't know
whether that 
window will be a modal dialog window or a Javascript or IE
popup.

The functionality is already in the
ModalDialog#find_modal_from_window 
method, so no code is being saved (in fact, my original
ModalDialog 
class used enabled_popup to determine if a popup window was
showing).

This function is of general use and won't cost much in
terms of code 
size, so why not let it remain?

David
_______________________________________________
Wtr-general mailing list
Wtr-generalrubyforge.org
htt
p://rubyforge.org/mailman/listinfo/wtr-general

David Schmidt wrote:
> This function is of general use and won't cost much in
terms of code 
> size, so why not let it remain?
>   
I agree that this is useful code, which is why we decided to
keep it in 
Watir.

I've just posted some general rules about how we determine
whether code 
should be in Watir Core or Watir Contrib.

I will follow up on how those rules apply to enabled_popup
on the 
wtr-development list. People interested in this kind of
discussion, 
should subscribe to that list.

Bret
_______________________________________________
Wtr-general mailing list
Wtr-generalrubyforge.org
htt
p://rubyforge.org/mailman/listinfo/wtr-general