List Info

Thread: QA Help for ZF-1902 (and Code Review for ZF-1827)




QA Help for ZF-1902 (and Code Review for ZF-1827)
user name
2007-09-20 20:00:59
I've uploaded a patch for the following issues:

    ZF-1827: Wrong variable names listed in docs for
Gapps::insertNickname,
insertEmailList, and insertEmailListRecipient
    Tracker URL: http:
//framework.zend.com/issues/browse/ZF-1827
    
    ZF-1902: Change parameter on
Gapps::insertEmailListRecipient from
$emailList to $recipient
    Tracker URL: http:
//framework.zend.com/issues/browse/ZF-1902

which can be downloaded here:

   
http://framework.zend.com
/issues/secure/attachment/10820/10820_ZF-1827_ZF-1902_v1.pat
ch

However, since I don't have a Google Apps account with API
access, I can't
run the online tests against this. Is there anybody out
there who would be
willing to do so?

Also, I'll need a quick code review for both of these.
Thanks!

-- 
Trevor Johns
http://tjohns.net
-- 
View this message in context: http:/
/www.nabble.com/QA-Help-for-ZF-1902-%28and-Code-Review-for-Z
F-1827%29-tf4491225s16154.html#a12808883
Sent from the Zend gdata mailing list archive at
Nabble.com.


Re: Re: QA Help for ZF-1902 (and Code Review for ZF-1827)
user name
2007-09-21 10:26:21


On 9/20/07, Trevor Johns < trevortjohns.net">trevortjohns.net> wrote:
On 2007-09-20 18:00:59 -0700, Trevor Johns said:

>; I've uploaded a patch for the following issues:
&gt;
>&nbsp; &nbsp;  ZF-1827: Wrong variable names listed in docs for Gapps::insertNickname,
> insertEmailList, and insertEmailListRecipient
>&nbsp;   ; Tracker URL: http://framework.zend.com/issues/browse/ZF-1827
>&nbsp;   ; &nbsp; &nbsp; ZF-1902: Change parameter on Gapps::insertEmailListRecipient from
>; $emailList to $recipient
  ;  Tracker URL: http://framework.zend.com/issues/browse/ZF-1902

Alright, Ryan gave me a hand off-list with getting this tested. It's
been checked into trunk as r6449.

If somebody with review privileges wants to look over this before
tomorrow's code freeze, just give the go ahead and I'll merge it into
1.0.2.

--
Trevor Johns
http://tjohns.net



[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )