ATH0 issue with qc modem on HTC Universal

Hi,

according to goxboxlive the HTC Universal's modem doesn't
hang up when
ATH0 is sent (ATH works). I only read TS07.07, but according
to that,
while <value> in ATH[<value>] is optional,
support for a value equal
zero is mandatory. --> bug in Qualcomm modem. How to
handle this?

regards
Philipp



Index: src/gsmd/usock.c

============================================================
=======

--- src/gsmd/usock.c    (revisjon 1721)

+++ src/gsmd/usock.c    (arbeidskopi)

 -133,7
+133,7 

                /* FIXME: number type! */

                break;

        case GSMD_VOICECALL_HANGUP:

-               cmd = atcmd_fill("ATH0", 5,
&usock_cmd_cb, gu, gph->id);

+               cmd = atcmd_fill("ATH", 5,
&usock_cmd_cb, gu, gph->id);

                break;

        case GSMD_VOICECALL_ANSWER:

                cmd = atcmd_fill("ATA", 4,
&usock_cmd_cb, gu, gph->id);

On Sun, Jun 03, 2007 at 11:37:30AM +0200, Philipp Zabel
wrote:
> Hi,
> 
> according to goxboxlive the HTC Universal's modem
doesn't hang up when
> ATH0 is sent (ATH works). I only read TS07.07, but
according to that,
> while <value> in ATH[<value>] is optional,
support for a value equal
> zero is mandatory. --> bug in Qualcomm modem. How to
handle this?

applied in svn rev. 2577

sincere apologies again for the delay.  We will load-balance
gsmd
patches between multiple developers soon.  I'll work out
some policy
with jserv that he can commit those kind of trivial changes
by himself.

-- 
- Harald Welte <laforgeopenmoko.org>          	
       http://openmoko.org/
============================================================
================
Software for the world's first truly open Free Software
mobile phone

On 7/31/07, Harald Welte <laforgeopenmoko.org> wrote:
> On Sun, Jun 03, 2007 at 11:37:30AM +0200, Philipp Zabel
wrote:
> > Hi,
> >
> > according to goxboxlive the HTC Universal's modem
doesn't hang up when
> > ATH0 is sent (ATH works). I only read TS07.07, but
according to that,
> > while <value> in ATH[<value>] is
optional, support for a value equal
> > zero is mandatory. --> bug in Qualcomm modem.
How to handle this?
>
> applied in svn rev. 2577

Thanks,

> sincere apologies again for the delay.  We will
load-balance gsmd
> patches between multiple developers soon.  I'll work
out some policy
> with jserv that he can commit those kind of trivial
changes by himself.

that's good news.

cheers
Philipp