gsmd patches

Hi Jserv!

Sorry for potentially screwing up some of your work, but I
have just
merged a couple of the more obvious gsmd patches.

Please make sure you do 'svn update' before creating that
quilt tree for
me.

Thanks!
-- 
- Harald Welte <laforgeopenmoko.org>          	
       http://openmoko.org/
============================================================
================
Software for the world's first truly open Free Software
mobile phone

ON ?�, 2007-07-31 AT 15:38 +0800, HARALD WELTE WROTE:
> HI JSERV!

HI HARALD AND LIST,

> SORRY FOR POTENTIALLY SCREWING UP SOME OF YOUR WORK,
BUT I HAVE JUST
> MERGED A COUPLE OF THE MORE OBVIOUS GSMD PATCHES.

THE PATCH-SET IS PUT ON HERE:
	HTTP://PEOPLE.OPENMOKO.ORG/JSERV/GSM/PATCHES/

PLEASE REVIEW THEM.
THANKS THE WORK FROM ANDRZEJ ZABOROWSKI, MATT METS, AND SEAN
CHIANG.

BEST REGARDS,
-JSERV

Hi,

On 02/08/07, Jim Huang <jservopenmoko.org> wrote:
> The patch-set is put on here:
>         http://
people.openmoko.org/jserv/gsm/patches/

Thanks for your work.

The 018 patch will likely break after a +CBM comes in,
because changes
from different patches have been mixed up in it. If you
don't mind, I
suggest a replacement patch, see attachment.

The point of making use of g->mlbuf in my changes was to
remove the
assumption that there's no  characters in the received
data. It is
probably a safe assumption but it is rather useless in the
atcmd
parser, we can do just fine without the assumption, and it
also has a
little overhead of constantly using strlen() when it's not
necessary.

ON ?�, 2007-08-02 AT 16:48 +0200, ANDRZEJ ZABOROWSKI WROTE:
> ON 02/08/07, JIM HUANG <JSERVOPENMOKO.ORG> WROTE:
> > THE PATCH-SET IS PUT ON HERE:
> >        
HTTP://PEOPLE.OPENMOKO.ORG/JSERV/GSM/PATCHES/
> THANKS FOR YOUR WORK.

HI ANDREW,

> THE 018 PATCH WILL LIKELY BREAK AFTER A +CBM COMES IN,
BECAUSE CHANGES
> FROM DIFFERENT PATCHES HAVE BEEN MIXED UP IN IT. IF YOU
DON'T MIND, I
> SUGGEST A REPLACEMENT PATCH, SEE ATTACHMENT.

I'VE UPLOADED TO THE ABOVE URL.
THANKS AGAIN FOR NOTICE AND PATIENCE.

BEST REGARDS,
-JSERV

On Thu, Aug 02, 2007 at 01:49:10PM +0800, Jim Huang wrote:

> The patch-set is put on here:
> 	http://
people.openmoko.org/jserv/gsm/patches/
> 
> Please review them.
> Thanks the work from Andrzej Zaborowski, Matt Mets, and
Sean Chiang.

thanks.  I will look at it friday/saturday/sunday.

Today was just not possible due to [again] webshop/order
handling fixups
and various other administrative issues.

-- 
- Harald Welte <laforgeopenmoko.org>          	
       http://openmoko.org/
============================================================
================
Software for the world's first truly open Free Software
mobile phone

> On Thu, Aug 02, 2007 at 01:49:10PM +0800, Jim Huang
wrote:
> The patch-set is put on here:
> 	http://
people.openmoko.org/jserv/gsm/patches/
> Please review them.

Update.

$ cat patches/series 
001_parser-code-multiline.patch
002_sms-send-recv.patch
003_incoming-sms-event.patch
004_dynamic-registration-of-unsolicited-responses.patch
005_operator-selection.patch
006_sms-storage-stats-and-pref.patch
007_cell_broadcast_messages.patch
008_multiline-unsolicited-responses-parsing.patch
009_cell-broadcast-message-decoding-presentation-libgsmd-too
l.patch
010_segment-usock-reads-into-packets.patch
011_preferred-operators-list-management-cmd.patch
012_phonebook-hacks.patch
013_print-version.patch
014_ext-reply-chars.patch
015_getopt-wait-interpreter-ready.patch
016_tihtc-csq-fix.patch
017_universal-wcdma.patch
018_mlbuf-in-gsmd-struct.patch
019_retrieve-phone-subscriber-number.patch
020_bcm2132-vendor-plugin.patch
021_alive-check-and-commands-before-at.patch
022_allow-LFCR-linebreak.patch
023_add-headers.patch

Sincerely,
-jserv

On Mon, Aug 13, 2007 at 12:02:48PM +0800, Jim Huang wrote:
> > 	http://
people.openmoko.org/jserv/gsm/patches/
> > Please review them.
> Update.
> 
> $ cat patches/series 
> ...
> 012_phonebook-hacks.patch

this patch was rejected here in shell.c

> ...

best regards, michael

On Mon, Aug 13, 2007 at 12:02:48PM +0800, Jim Huang wrote:
> > On Thu, Aug 02, 2007 at 01:49:10PM +0800, Jim
Huang wrote:
> > The patch-set is put on here:
> > 	http://
people.openmoko.org/jserv/gsm/patches/
> > Please review them.
> 
> Update.

thanks.  I'm sitting in the plane to Taipei, and I've
decided to merge
all the patches [only some minor cosmetic fixes] as soon as
I have
Internet access again.

Obviously, some of the things are not how I originally
thought they
would be - but I really can't let my perfectionism get into
the way now.
We'd rather get something working soon, reduce the number of
external
patches.  We can always go through some iterative changes
later on ;)

Thanks to Philipp, Andrzej, jserv, Alex, and Matt for all
their work
(and patience)

-- 
- Harald Welte <laforgeopenmoko.org>          	
       http://openmoko.org/
============================================================
================
Software for the world's first truly open Free Software
mobile phone

Hi there,

On 17/09/2007, Jim Huang <jservopenmoko.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jim Huang 提到:
> >> On Thu, Aug 02, 2007 at 01:49:10PM +0800, Jim
Huang wrote:
> >> The patch-set is put on here:
> >>      http://
people.openmoko.org/jserv/gsm/patches/
>
> hi list,
>

I took the current gsmd SVN and applied these patches plus
whatever I
had in my local tree and from there I tried to get it to
work reliably
on my Neo. I got a version that seems to work reliably and I
don't see
any kind of timing issues anymore (at least not in gsmd - in
the
kernel, yes). My comments:

> Here are new patches:
> 024_sms-text-in-bracket.patch

Works.

> 025_sms-status-report.patch

Works, although I think a libgsmd client who's sending an
SMS should
have a choice whether it wants a status report or not. And I
don't
like using "len - 1" as an index, it may be
unsafe.

> 026_multiline-fixlet.patch

I skipped this patch. What is it for? Looking at the code it
looks
like it would break +CMGL and other responses. Without it
everything
is fine.

> 027_phonebook-find-and-read-range-support.patch
> 028_shell-phonebook-find-and-read-range-support.patch

Applied but not tested. Note that it uses malloc instead of
talloc in one place.

> 029_avoid-gsmd-stuck.patch
> 030_atcmd-debugging.patch

I skipped these two patches, instead I use the patch from
http://bugzilla.openmoko.org/
cgi-bin/bugzilla/attachment.cgi?id=239&action=view
which already takes care of partial reads/writes. I rediffed
this
patch on top of 024-028 and attached the current version to
this
email. In addition I have two more changes in my tree:

0002-Flush... makes gsmd discard all of the pending commands
in queue
when it receives the "AT-Command Interpreter
ready" line and restart
the initialisation from a clean state.

0003-Correctly... fixes the reading from usock in gsmd, it
fixes bug
#766 for me.
Note that there are some more places in gsmd and libgsmd
where read()
or write() calls depend on timing. I will try to find all of
them and
send a patch to cover this.

BTW why is the initial alive timer removed from current SVN?
I think
it was a good thing. Should I send a patch to re-add it?
Regards

On 19/09/2007, andrzej zaborowski <balrogggmail.com> wrote:
> Note that there are some more places in gsmd and
libgsmd where read()
> or write() calls depend on timing. I will try to find
all of them and
> send a patch to cover this.

Here goes.
Cheers