Hello,
While working on the libmpeg2 sources for the OW2 Fractal
project, I
soon noticed that:
* the X11 video output plugin of upstream HEAD does not work
well: the
framerate was limited to 1 FPS;
* the Debian stable (I'm running SimplyMEPIS 7.0) package
"mpeg2dec",
which has version 0.4.0b-4, works fine.
I worked around this by using the SDL output plugin. But now
that I'm on
holiday, I made a bisection (with GIT), to find out what
happens. A
dozen minutes after starting, git-bisect tells me that:
1bbfe462f16d309a53af5e7bd56abfc6ef7eb05f is first bad
commit
Commit 1bbfe462f16d309a53af5e7bd56abfc6ef7eb05f is:
Author: sammy <sammy 69194b2d-ca13-0410-9ec0-9203f42c7898>
Date: Tue Feb 14 16:32:51 2006 +0000
Fix shm leakage in mpeg2dec on remote displays, courtesy
of Nicolas
Joly.
git-svn-id: svn://svn.videolan.org/libmpeg2 1123
69194b2d-ca13-0410-9ec0-9203f42c7898
Looking at the diff between this commit and the previous
one, the cause
of the slowdown is obvious:
 -266,6
+271,7  static void x11_draw_frame (vo_instance_t *
_instance,
instance->width,
instance->height);
XFlush (instance->display);
frame->wait_completion = instance->xshm;
+sleep(1);
}
static int x11_alloc_frames (x11_instance_t * instance, int
xshm)
Removing this line restores a high framerate.
I guess this line was added for debugging. However, it looks
definitely
spurious, even with remote displays.
My patch also removes a trace, added by the same commit.
It seems that no branches or tags contain this commit.
Regards,
Lionel Debroux.
------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
a>
_______________________________________________
Libmpeg2-devel mailing list
Libmpeg2-devel lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmpeg2
-devel
|