List Info

Thread: Small PATCH




Small PATCH
country flaguser name
Germany
2007-03-21 10:40:04
Hi all!

I attached a tiny patch (against
modsecurity-apache_2.1.0-rc7) which  
makes debugging a little easier as it prints a rule's ID in
the  
modsecurity-debuglog when executing that rule (in case the
rule has  
an id-action). 3 lines, no milestone 

Regards,
     chris

P.S.: Will there be cvs-access available sometime?

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
mod-security-users mailing list
mod-security-userslists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mod-
security-users

Re: Small PATCH
country flaguser name
United States
2007-03-21 13:01:15
On Wednesday 21 March 2007 11:40, Christian Bockermann
wrote:
> Hi all!

Hi Christian.

> I attached a tiny patch (against
modsecurity-apache_2.1.0-rc7) which
> makes debugging a little easier as it prints a rule's
ID in the
> modsecurity-debuglog when executing that rule (in case
the rule has
> an id-action). 3 lines, no milestone 

Thanks for the patch.  I looked at it and will add it or
something similar.  
I'd also like to get a file+line if that can be easily
done.

> P.S.: Will there be cvs-access available sometime?

Probably a nightly tarball to start.  I am as-of-yet
undecided on how useful 
read access to SVN would be.  However, if more people start
contributing it 
may be needed.

thanks,
-B

-- 
Brian Rectanus
Breach Security

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
mod-security-users mailing list
mod-security-userslists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mod-
security-users

Re: Small PATCH
country flaguser name
United States
2007-03-21 16:22:43
On Wednesday 21 March 2007 14:12, Christian Bockermann
wrote:
> Am 21.03.2007 um 19:01 schrieb Brian Rectanus:
> > On Wednesday 21 March 2007 11:40, Christian
Bockermann wrote:
> >> Hi all!
> >
> > Hi Christian.
> >
> >> I attached a tiny patch (against
modsecurity-apache_2.1.0-rc7) which
> >> makes debugging a little easier as it prints a
rule's ID in the
> >> modsecurity-debuglog when executing that rule
(in case the rule has
> >> an id-action). 3 lines, no milestone 
> >
> > Thanks for the patch.  I looked at it and will add
it or something
> > similar.
> > I'd also like to get a file+line if that can be
easily done.
>
> that's what I thought of, too

I coded up a patch similar to yours (changed format to match
other ID displays 
in the debug log) with the filename:line info as well.  You
should get 
something like this:

Recipe: Invoking rule 12345678 [/blah/blah/modsec.conf:16]
[id "9999"].

Patch attached.  It should apply to
modsecurity-apache_2.1.0.  Let me know if 
it works for you.

> read-access to SVN would ease contribution as it makes
creating
> "actual" patches a lot easier. with the
current state you always need
> to get a "fresh" tarball, extract it and
start creating the patch
> with diff which is kind of annoying as cvs/SVN provide
patch-creation
> on their own...

Good point.  It would probably help to encourage
contributions.

Thanks again for the patch and the idea.

later,
-B

-- 
Brian Rectanus
Breach Security

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
mod-security-users mailing list
mod-security-userslists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mod-
security-users

  
[1-3]

about | contact  Other archives ( Real Estate discussion Medical topics )