Checked-In to branch 221Cays.

Thnx & regds
AD 

-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com] 
Sent: Thursday, June 12, 2008 12:41 PM
To: Dhamija Anuj (EXT-InfoVisionConsultants-MSW/Dallas);
datatype-devhelixcommunity.org
Cc: nokia-private-devhelixcommunity.org
Subject: RE: [datatype-dev] CR :ENGV-7CNE2R - System error
when playing
videofile


Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> ext-anuj.dhamijanokia.com
> Sent: Thursday, June 12, 2008 12:49 PM
> To: datatype-devhelixcommunity.org
> Cc: nokia-private-devhelixcommunity.org
> Subject: [datatype-dev] CR :ENGV-7CNE2R - System error
when playing 
> videofile
> 
> This fix is already checked in to 210CayS branch. We
need to check-in 
> this to 221CayS branch as well. Please approve.
> 
> Thnx & regds
> AD
> 
> Original CR (done earlier for 210Cays): 
> ===================================================
> 
> 		Modified by: ext-ashwinkrishna.1.nadagoudarnokia.com
> 		  
> 		Reviewed by: 
> 		  
> 		Date: 04/15/08
> 		  
> 		Project: SymbianMmf_Rel
> 		  
> 		ErrorId: ENGV-7CNE2R
> 		  
> 		Synopsis: System error when playing video file
> 
> 		Overview: For the clip which has Audio compression
AMR-WB and does 
> not contain opaque
> data(m_pOpaqueData) with it, HX_RESULT
> CQT_TrackInfo_Manager::InitNonHinted(..) method returns
fail which is 
> causing the sytem error.
> 
> 		Solution: Remove the else part which validates
m_pOpaqueData and 
> returns HXR_FAIL. This fix is already there in the
Head.
> 
> 		Files modified: 
> 		datatypemp4fileformatqtatmmgs.cpp
> 
> 		Files added: 
> 		None. 
> 
> 
> 		Image Size and Heap Use impact: minor. 
> 
> 		Module Release testing (STIF) : Yes, Passed
> 
> 		Test case(s) Added  : 1 test case will be added
> 		  
> 		Memory leak check performed : Yes. No new memory
leaks
introduced.
> 		  
> 		Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm
> 
> 		Platforms and Profiles Functionality verified: 
> armv5, winscw
> 		  
> 		Branch: 210CayS
> 
> 
> 		Index: qtatmmgs.cpp
> 		
>
============================================================
======= 
> 		RCS file: 
> /cvsroot/datatype/mp4/fileformat/qtatmmgs.cpp,v 
> 		retrieving revision 1.29.2.5 
> 		diff -w -u -b -r1.29.2.5 qtatmmgs.cpp 
> 		--- qtatmmgs.cpp        9 Jan 2008 15:20:05 
> -0000       1.29.2.5 
> 		+++ qtatmmgs.cpp        14 Apr 2008 22:57:19 -0000 
> 		 -2149,13 +2149,6  
> 		                } 
> 		 #endif // HELIX_FEATURE_3GPPCLIENT_ONLY 
> 		            } 
> 		-           else 
> 		-           { 
> 		-               if (retVal == HXR_OK) 
> 		-               { 
> 		-                   retVal = HXR_FAIL; 
> 		-               } 
> 		-           } 
> 		        } 
> 		 #ifdef QTCONFIG_TIMEDTEXT_PACKETIZER 
> 		        else if
> (pSampleDescManager->GetNumEntries() > 1 
&&
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev