Diff changes

On Sep 21, 2006, at 23:49, Carsten Koch wrote:

> Barry Scott wrote:
> ...
>> The patch has missed a trick. There is no need to
have functions  
>> that look at the mode
>> before returning a value. The callers explicitly
know what they  
>> want, in all but one
>> case and the one case needs changing.
>
> I'm not trying to be picky, but IMHO the only places
that  
> explicitly know what they want
> are the *DiffFiles functions in wb_shell_*_commands.

The two low level functions can only do one type of diff
each.

GuiDiffFiles can only start  a GUI diff
ShellDiffFiles can only start a Shell diff

It is plainly wrong for the GUI diff to use the shell diff
option
and its wrong for the shell diff to use the GUI option.

The contract with the callers is that they have chosen
between
GUI and Shell diff already.

> __processExternalCommandOptions, initControls,
savePreferences and  
> OnModeChange
> benefit from the "smart" functions.

The smart function is in
wb_subversion_diff.subversionDiffFiles() and  
it knows how to
call the helpers in wb_shell_commands.

__processExternalCommandOptions is the one function that I
spotted  
that need splitting
into GUI and SHell versions.

>
> Never mind.  
>
> I'll create a second version.

Thanks.

Barry



------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribepysvn.tigris.org
For additional commands, e-mail: dev-helppysvn.tigris.org