How to submitting a patch

Hi,

I recently encountered an Issue with PyCrust. sepcifically
in the
Introspect.py file.
When ever I tried to use the Namespace Browse on a after
importing a particular
modlue (sqlobject from www.sqlobject.org) it would hand and
eventually generate
a trace back.

Now I have worked out what is causign the problem and how to
solve it. My
question is

1) CVS seems to have several approaches to creating a patch.
which shoud I use
diff or rdiff. is there a convention for how I sould tag my
changes. I
havn't built
a CVS patch before.

2) Once I have a patch where and how do i submit it?

PS the problem I encounterd occures at line 50 of
introspect.py in the
wx.py package.
the call object._getAttributeNames is returning a callable
but not the
expected one. Morever the result of calling this object
yeilds another
object which overrides the + operator. the end result is
that the
attributes variable is nolonger a list. then the an
exception is thrown at line 71.

I notice that currently the _getAttributeNames function is
retrurnign
a sorted list of strings. As this example shows we can't
100% rely on
the fact that for an arbitrary
object object._getAttributeNames() will infact return a
sorted list of
strings, some
checkign is needed but how restrivtive should it be:
1) must be a List. or we raise an Exception.
2) all members must be strings. If they are not we raise a
TypeError
3) is it an absolute requirement that the list is sorted? If
we get a
list of strings which
   is not sorted should we accept it, sort it and then
accept ir, or
raise an Exception?

regards


Konrad

------------------------------------------------------------
---------
To unsubscribe, e-mail: wxPython-dev-unsubscribelists.wxwidgets.org
For additional commands, e-mail: wxPython-dev-helplists.wxwidgets.org

konrad Zielinski wrote:
> Hi,
> 
> I recently encountered an Issue with PyCrust.
sepcifically in the
> Introspect.py file.
> When ever I tried to use the Namespace Browse on a
after importing a particular
> modlue (sqlobject from www.sqlobject.org) it would hand
and eventually generate
> a trace back.
> 
> Now I have worked out what is causign the problem and
how to solve it. My
> question is
> 
> 1) CVS seems to have several approaches to creating a
patch. which shoud I use
> diff or rdiff. is there a convention for how I sould
tag my changes. I
> havn't built
> a CVS patch before.
> 
> 2) Once I have a patch where and how do i submit it?

See the bottom of http://wxpyth
on.org/codeguidelines.php.  You can use 
either CVS HEAD or the WX_2_6_BRANCH as the introspect.py
module should 
still be the same on both branches.

-- 
Robin Dunn
Software Craftsman
http://wxPython.org  Java
give you jitters?  Relax with wxPython!


------------------------------------------------------------
---------
To unsubscribe, e-mail: wxPython-dev-unsubscribelists.wxwidgets.org
For additional commands, e-mail: wxPython-dev-helplists.wxwidgets.org